Suppressed MEs for gestures from cancelled PEs

ui/events/event.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_EVENTS_EVENT_H_
 #define UI_EVENTS_EVENT_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 1031 matching lines @@
   float y_offset_;
   // Unaccelerated offsets.
   float x_offset_ordinal_;
   float y_offset_ordinal_;
   // Number of fingers on the pad.
   int finger_count_;
 };
 
 class EVENTS_EXPORT GestureEvent : public LocatedEvent {
  public:
+    // The constructor takes a default unique_touch_id of zero because test

[Rick Byers, 2016/06/09 16:07:33]

nit replace "because test" with "for tests."

[mustaq, 2016/06/09 16:41:03]

Ooops, had dropped the long line accidentally.

   GestureEvent(float x,
                float y,
                int flags,
                base::TimeDelta time_stamp,
-               const GestureEventDetails& details);
+               const GestureEventDetails& details,
+               uint32_t unique_touch_event_id = 0);
 
   // Create a new GestureEvent which is identical to the provided model.
   // If source / target windows are provided, the model location will be
   // converted from |source| coordinate system to |target| coordinate system.
   template <typename T>
   GestureEvent(const GestureEvent& model, T* source, T* target)
       : LocatedEvent(model, source, target),
         details_(model.details_) {
   }
 
   ~GestureEvent() override;
 
   const GestureEventDetails& details() const { return details_; }
 
+  uint32_t unique_touch_event_id() const {
+    return unique_touch_event_id_;
+  }
+
  private:
   // For (de)serialization.
   GestureEvent(EventType type, base::TimeDelta time_stamp, int flags)
       : LocatedEvent(type, time_stamp, flags) {}
   friend struct IPC::ParamTraits<ui::ScopedEvent>;
   friend struct IPC::ParamTraits<ui::GestureEvent>;
 
   GestureEventDetails details_;
+
+  // The unique id of the touch event that released the gesture event. This
+  // field gets a non-zero value only for gestures that are released through
+  // TouchDispositionGestureFilter::SendGesture.
+  uint32_t unique_touch_event_id_;

[sadrul, 2016/06/09 16:49:15]

"""The unique id of the touch event that released the gesture event.""" ==> this
initially lead me to think that this is valid only for gesture-end event-types.
But I think what you mean the touch-event that triggered the gesture event to be
dispatched, so I would change the phrasing a bit (e.g. 'The unique id of the
touch event that caused the gesture event to be dispatched.').

Also, for gesture events that aren't dispatched directly in response to
processing a touch-event (e.g. the long-press gesture, which is dispatched in
response to a timer running out), what does this id mean? The first touch-event
that caused this gesture-event to be generated? Can you clarify in the comment
here?

[mustaq, 2016/06/09 17:17:27]

Does it sound better?

 };
 
 }  // namespace ui
 
 #endif  // UI_EVENTS_EVENT_H_