Suppressed MEs for gestures from cancelled PEs

ui/events/event.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_EVENTS_EVENT_H_
 #define UI_EVENTS_EVENT_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 1035 matching lines @@
   // Number of fingers on the pad.
   int finger_count_;
 };
 
 class EVENTS_EXPORT GestureEvent : public LocatedEvent {
  public:
   GestureEvent(float x,
                float y,
                int flags,
                base::TimeDelta time_stamp,
                const GestureEventDetails& details);

[Rick Byers, 2016/06/08 20:42:48]

Should we plan to eliminate this ctor variant eventually?  Have you spot checked
the existing callers to see if any look like they could be sources of bugs (code
paths where the unique_touch_event_id gets dropped)?

[mustaq, 2016/06/08 20:53:16]

We have 83 calls to this ctor, only 4 of them are in non-test code:
src/ash/drag_drop/drag_drop_controller.cc
src/ui/events/gestures/gesture_provider_aura.cc
src/ui/events/ozone/evdev/event_factory_evdev.cc
src/ui/events/test/event_generator.cc

Only the third one is related to gestures released through touches which has
been fixed here.

Is there any way to mark the old ctor as test-only? Like Java
@VisibleForTesting?

 
+  GestureEvent(float x,
+               float y,
+               int flags,
+               base::TimeDelta time_stamp,
+               const GestureEventDetails& details,
+               uint32_t unique_touch_event_id);
+
   // Create a new GestureEvent which is identical to the provided model.
   // If source / target windows are provided, the model location will be
   // converted from |source| coordinate system to |target| coordinate system.
   template <typename T>
   GestureEvent(const GestureEvent& model, T* source, T* target)
       : LocatedEvent(model, source, target),
         details_(model.details_) {
   }
 
   ~GestureEvent() override;
 
   const GestureEventDetails& details() const { return details_; }
 
+  uint32_t unique_touch_event_id() const {
+    return unique_touch_event_id_;
+  }
+
  private:
   // For (de)serialization.
   GestureEvent(EventType type, base::TimeDelta time_stamp, int flags)
       : LocatedEvent(type, time_stamp, flags) {}
   friend struct IPC::ParamTraits<ui::ScopedEvent>;
   friend struct IPC::ParamTraits<ui::GestureEvent>;
 
   GestureEventDetails details_;
+  uint32_t unique_touch_event_id_;
 };
 
 }  // namespace ui
 
 #endif  // UI_EVENTS_EVENT_H_