Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: third_party/WebKit/Source/core/input/TouchEventManager.cpp

Issue 1989623002: Suppressed MEs for gestures from cancelled PEs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/TouchEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/TouchEventManager.cpp b/third_party/WebKit/Source/core/input/TouchEventManager.cpp
index 200fe65e19c46d23a5dd977a52e76493cb453cdf..7b6d67c9a10f3c950a27b149f89f2102af6bc0e4 100644
--- a/third_party/WebKit/Source/core/input/TouchEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/TouchEventManager.cpp
@@ -444,15 +444,6 @@ WebInputEventResult TouchEventManager::handleTouchEvent(
if (!reHitTestTouchPointsIfNeeded(event, touchInfos))
return WebInputEventResult::NotHandled;
- // Note that the disposition of any pointer events affects only the generation of touch
- // events. If all pointer events were handled (and hence no touch events were fired), that
- // is still equivalent to the touch events going unhandled because pointer event handler
- // don't block scroll gesture generation.
-
- // TODO(crbug.com/507408): If PE handlers always call preventDefault, we won't see TEs until after
- // scrolling starts because the scrolling would suppress upcoming PEs. This sudden "break" in TE
- // suppression can make the visible TEs inconsistent (e.g. touchmove without a touchstart).
-
bool allTouchesReleased = true;
for (const auto& point : event.touchPoints()) {
if (point.state() != PlatformTouchPoint::TouchReleased
« no previous file with comments | « third_party/WebKit/Source/core/input/TouchEventManager.h ('k') | third_party/WebKit/Source/platform/PlatformGestureEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698