Add DRP client config tests for secure proxy check

Add DRP client config tests for secure proxy check

These tests make sure that client config plays well with
the secure proxy check.

Also, remove an unused function from DRP configurator.

BUG=

Committed: https://crrev.com/8f0410ffae0fed84cba6f395c975deda14955c9b
Cr-Commit-Position: refs/heads/master@{#394590}

[tbansal1, 2016-05-18 21:49:25]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-05-18 21:55:41]

Description was changed from

==========
Add some tests

BUG=
==========

to

==========
Add DRP client config tests for secure proxy check

These tests make sure that client config plays well with
the secure proxy check.

Also, remove an unused function from DRP configurator.

BUG=
==========

[tbansal1, 2016-05-18 21:56:00]

tbansal@chromium.org changed reviewers:
+ sclittle@chromium.org

[tbansal1, 2016-05-18 21:56:01]

sclittle: ptal. Thanks.

[sclittle, 2016-05-18 22:06:23]

lgtm

https://codereview.chromium.org/1989243003/diff/20001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
(right):

https://codereview.chromium.org/1989243003/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc:168:
TEST_F(DataReductionProxyConfigTest, TestUpdateConfigurator) {
FYI: I'm also changing this test to actually use an HTTPS proxy, so that it
actually disappears from the proxy list when restricted. I can just build that
on top of this though.

[tbansal1, 2016-05-18 22:10:04]

https://codereview.chromium.org/1989243003/diff/20001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
(right):

https://codereview.chromium.org/1989243003/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc:168:
TEST_F(DataReductionProxyConfigTest, TestUpdateConfigurator) {
On 2016/05/18 22:06:23, sclittle wrote:
> FYI: I'm also changing this test to actually use an HTTPS proxy, so that it
> actually disappears from the proxy list when restricted. I can just build that
> on top of this though.

Acknowledged.

[tbansal1, 2016-05-18 22:10:10]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2016-05-18 22:10:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1989243003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1989243003/20001

[commit-bot: I haz the power, 2016-05-18 23:11:54]

Description was changed from

==========
Add DRP client config tests for secure proxy check

These tests make sure that client config plays well with
the secure proxy check.

Also, remove an unused function from DRP configurator.

BUG=
==========

to

==========
Add DRP client config tests for secure proxy check

These tests make sure that client config plays well with
the secure proxy check.

Also, remove an unused function from DRP configurator.

BUG=
==========

[commit-bot: I haz the power, 2016-05-18 23:11:54]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-05-18 23:13:29]

Description was changed from

==========
Add DRP client config tests for secure proxy check

These tests make sure that client config plays well with
the secure proxy check.

Also, remove an unused function from DRP configurator.

BUG=
==========

to

==========
Add DRP client config tests for secure proxy check

These tests make sure that client config plays well with
the secure proxy check.

Also, remove an unused function from DRP configurator.

BUG=

Committed: https://crrev.com/8f0410ffae0fed84cba6f395c975deda14955c9b
Cr-Commit-Position: refs/heads/master@{#394590}
==========

[commit-bot: I haz the power, 2016-05-18 23:13:30]

Patchset 1 (id:??) landed as
https://crrev.com/8f0410ffae0fed84cba6f395c975deda14955c9b
Cr-Commit-Position: refs/heads/master@{#394590}