Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_test_utils.h

Issue 1989243003: Add DRP client config tests for secure proxy check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_test_utils.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_test_utils.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_test_utils.h
index ba982b6fc4400760c746e28594ce9a284cd902eb..c5fa64a6ca5ef04251ebcfce32ba5adf35aae828 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_test_utils.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_test_utils.h
@@ -8,6 +8,7 @@
#include <string>
#include <vector>
+#include "base/macros.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h"
namespace net {
@@ -33,10 +34,6 @@ class TestDataReductionProxyConfigurator
void Disable() override;
- void AddHostPatternToBypass(const std::string& pattern) override {}
-
- void AddURLPatternToBypass(const std::string& pattern) override {}
-
bool enabled() const {
return enabled_;
}
@@ -45,9 +42,9 @@ class TestDataReductionProxyConfigurator
return restricted_;
}
- const std::vector<net::ProxyServer>& proxies_for_http() const {
- return proxies_for_http_;
- }
+ // Returns the proxies in use by the proxy config. May include the DIRECT
+ // proxy.
+ const std::vector<net::ProxyServer>& proxies_for_http() const;
private:
// True if the proxy has been enabled, i.e., only after |Enable| has been
@@ -59,8 +56,7 @@ class TestDataReductionProxyConfigurator
// to false.
bool restricted_;
- // The origins that are passed to |Enable|.
- std::vector<net::ProxyServer> proxies_for_http_;
+ DISALLOW_COPY_AND_ASSIGN(TestDataReductionProxyConfigurator);
};
} // namespace data_reduction_proxy

Powered by Google App Engine
This is Rietveld 408576698