components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc - Issue 1989243003: Add DRP client config tests for secure proxy check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

Issue 1989243003: Add DRP client config tests for secure proxy check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

index 6f90a4d817cb43c4b6afe761f81ed9f24ecfcb71..e150ff96e9e3f05f86e14befe4c87332fb9862c8 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

@@ -169,18 +169,33 @@ TEST_F(DataReductionProxyConfigTest, TestUpdateConfigurator) {

ResetSettings(true, true, true, false);

std::vector<net::ProxyServer> expected_http_proxies;

- config()->UpdateConfigurator(true, false);

+ config()->UpdateConfigurator(true /* enabled */,

+ true /* secure_proxy_allowed */);

EXPECT_TRUE(configurator()->enabled());

expected_http_proxies.push_back(net::ProxyServer::FromURI(

params()->DefaultOrigin(), net::ProxyServer::SCHEME_HTTP));

expected_http_proxies.push_back(net::ProxyServer::FromURI(

params()->DefaultFallbackOrigin(), net::ProxyServer::SCHEME_HTTP));

+ expected_http_proxies.push_back(net::ProxyServer::Direct());

EXPECT_THAT(configurator()->proxies_for_http(),

testing::ContainerEq(expected_http_proxies));

- config()->UpdateConfigurator(false, false);

+ config()->UpdateConfigurator(false /* enabled */,

+ false /* secure_proxy_allowed */);

EXPECT_FALSE(configurator()->enabled());

EXPECT_TRUE(configurator()->proxies_for_http().empty());

+ config()->UpdateConfigurator(true /* enabled */,

+ false /* secure_proxy_allowed */);

+ EXPECT_TRUE(configurator()->enabled());

+ expected_http_proxies.clear();

+ expected_http_proxies.push_back(net::ProxyServer::FromURI(

+ params()->DefaultOrigin(), net::ProxyServer::SCHEME_HTTP));

+ expected_http_proxies.push_back(net::ProxyServer::FromURI(

+ params()->DefaultFallbackOrigin(), net::ProxyServer::SCHEME_HTTP));

+ expected_http_proxies.push_back(net::ProxyServer::Direct());

+ EXPECT_THAT(configurator()->proxies_for_http(),

+ testing::ContainerEq(expected_http_proxies));

}

TEST_F(DataReductionProxyConfigTest, TestUpdateConfiguratorHoldback) {