Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 198873004: perf test: Add PerfTestRunner.logFatalError(text) (Closed)

Created:
6 years, 9 months ago by dshwang
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

perf test: Add PerfTestRunner.logFatalError(text) Add PerfTestRunner.logFatalError(text) to stop a test if the test can not run. For example, WebGL is not supported on some platforms, so a WebGL perf test on the platform should stop. BUG=242244 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169380

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -72 lines) Patch
M PerformanceTests/Canvas/draw-dynamic-webgl-to-hw-accelerated-canvas-2d.html View 1 2 3 chunks +14 lines, -18 lines 0 comments Download
M PerformanceTests/Canvas/draw-static-webgl-to-hw-accelerated-canvas-2d.html View 1 2 3 chunks +13 lines, -17 lines 0 comments Download
M PerformanceTests/Canvas/upload-canvas-2d-to-texture.html View 2 chunks +12 lines, -15 lines 0 comments Download
M PerformanceTests/Canvas/upload-webgl-to-texture.html View 1 2 3 chunks +13 lines, -17 lines 0 comments Download
M PerformanceTests/resources/runner.js View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dshwang
rniwa@ made runner.js and then nobody touched. eseidel@, could you review this CL? It's preparation ...
6 years, 9 months ago (2014-03-17 17:15:17 UTC) #1
dshwang
https://codereview.chromium.org/198873004/diff/20001/PerformanceTests/Canvas/draw-dynamic-webgl-to-hw-accelerated-canvas-2d.html File PerformanceTests/Canvas/draw-dynamic-webgl-to-hw-accelerated-canvas-2d.html (right): https://codereview.chromium.org/198873004/diff/20001/PerformanceTests/Canvas/draw-dynamic-webgl-to-hw-accelerated-canvas-2d.html#newcode11 PerformanceTests/Canvas/draw-dynamic-webgl-to-hw-accelerated-canvas-2d.html:11: PerfTestRunner.logFatalError("\nWebGL is not supported or enabled on this platform!\n"); ...
6 years, 9 months ago (2014-03-17 17:16:03 UTC) #2
Ken Russell (switch to Gerrit)
Please set the BUG=242244 or to some other value before committing. LGTM
6 years, 9 months ago (2014-03-17 18:33:38 UTC) #3
dshwang
On 2014/03/17 18:33:38, Ken Russell wrote: > Please set the BUG=242244 or to some other ...
6 years, 9 months ago (2014-03-17 18:38:09 UTC) #4
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 9 months ago (2014-03-17 18:38:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/198873004/60001
6 years, 9 months ago (2014-03-17 18:38:18 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-17 19:15:04 UTC) #7
Message was sent while issue was closed.
Change committed as 169380

Powered by Google App Engine
This is Rietveld 408576698