Include symupload in official Blimp engine builds

Include symupload in official Blimp engine builds

This is needed in official builds as the symupload binary is needed to
upload crash symbol files to the crash server, but is not included on
the buildbots for reasons.

BUG=597454
Committed: https://crrev.com/5364fc6bd081393a667b7aef5ff6766b3b115af1
Cr-Commit-Position: refs/heads/master@{#394580}

[marcinjb, 2016-05-18 20:27:26]

marcinjb@chromium.org changed reviewers:
+ kmarshall@chromium.org

[marcinjb, 2016-05-18 20:27:27]

Last one for crash, I hope. After this lands, amineer@ and I will verify that
this is all that is needed for symbol file uploads.

[Kevin M, 2016-05-18 20:31:46]

lgtm

https://codereview.chromium.org/1987393002/diff/1/blimp/engine/BUILD.gn
File blimp/engine/BUILD.gn (right):

https://codereview.chromium.org/1987393002/diff/1/blimp/engine/BUILD.gn#newco...
blimp/engine/BUILD.gn:565: # Action to create a breakpad symbol file for the
engine. This can take
Capitalize: Breakpad, Engine

https://codereview.chromium.org/1987393002/diff/1/blimp/engine/BUILD.gn#newco...
blimp/engine/BUILD.gn:598: # Binary used by the buildbots to upload breakpad
symbols.
THis isn't a binary, just a dep list.

Any reason why we can't just add this to blimp_symbols' deps list? It looks like
we never reference blimp_symbols and symupload separately.

[marcinjb, 2016-05-18 20:42:04]

Barring any objections, I'll commit soon.

https://codereview.chromium.org/1987393002/diff/1/blimp/engine/BUILD.gn
File blimp/engine/BUILD.gn (right):

https://codereview.chromium.org/1987393002/diff/1/blimp/engine/BUILD.gn#newco...
blimp/engine/BUILD.gn:565: # Action to create a breakpad symbol file for the
engine. This can take
On 2016/05/18 20:31:46, Kevin M wrote:
> Capitalize: Breakpad, Engine

Done.

https://codereview.chromium.org/1987393002/diff/1/blimp/engine/BUILD.gn#newco...
blimp/engine/BUILD.gn:598: # Binary used by the buildbots to upload breakpad
symbols.
On 2016/05/18 20:31:46, Kevin M wrote:
> THis isn't a binary, just a dep list.
> 
> Any reason why we can't just add this to blimp_symbols' deps list? It looks
like
> we never reference blimp_symbols and symupload separately.

Well, with a level of indirection, symupload generates a binary.  I was going to
try to keep these separate, but you're right, one goes with the other, so I've
collapsed it.

[marcinjb, 2016-05-18 20:53:32]

The CQ bit was checked by marcinjb@chromium.org

[marcinjb, 2016-05-18 20:53:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
kmarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/1987393002/#ps20001
(title: "Move symupload dep into the blimp_symbols target")

[commit-bot: I haz the power, 2016-05-18 20:54:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987393002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987393002/20001

[commit-bot: I haz the power, 2016-05-18 22:53:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-18 22:54:47]

Description was changed from

==========
Include symupload in official Blimp engine builds

This is needed in official builds as the symupload binary is needed to
upload crash symbol files to the crash server, but is not included on
the buildbots for reasons.

BUG=597454
==========

to

==========
Include symupload in official Blimp engine builds

This is needed in official builds as the symupload binary is needed to
upload crash symbol files to the crash server, but is not included on
the buildbots for reasons.

BUG=597454

Committed: https://crrev.com/5364fc6bd081393a667b7aef5ff6766b3b115af1
Cr-Commit-Position: refs/heads/master@{#394580}
==========

[commit-bot: I haz the power, 2016-05-18 22:54:49]

Patchset 2 (id:??) landed as
https://crrev.com/5364fc6bd081393a667b7aef5ff6766b3b115af1
Cr-Commit-Position: refs/heads/master@{#394580}