Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: blimp/engine/BUILD.gn

Issue 1987393002: Include symupload in official Blimp engine builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move symupload dep into the blimp_symbols target Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//build/config/sanitizers/sanitizers.gni") 7 import("//build/config/sanitizers/sanitizers.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 import("//mojo/public/tools/bindings/mojom.gni") 9 import("//mojo/public/tools/bindings/mojom.gni")
10 import("//tools/grit/repack.gni") 10 import("//tools/grit/repack.gni")
(...skipping 542 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 _rebased_dockerfile, 553 _rebased_dockerfile,
554 "--startup-script", 554 "--startup-script",
555 _rebased_startup_script, 555 _rebased_startup_script,
556 "--manifest", 556 "--manifest",
557 _rebased_manifest, 557 _rebased_manifest,
558 "--output", 558 "--output",
559 rebase_path(_bundle), 559 rebase_path(_bundle),
560 ] 560 ]
561 } 561 }
562 562
563 # Creates a breakpad symbol file for the engine. This takes a long time so 563 # Crash symbols should only be created and uploaded from official builders.
564 # it should only be done as part of the official build.
565 if (is_official_build) { 564 if (is_official_build) {
565 # Action to create a Breakpad symbol file for the Engine. This can take
566 # a long time.
566 action("blimp_symbols") { 567 action("blimp_symbols") {
567 script = "//build/linux/dump_app_syms.py" 568 script = "//build/linux/dump_app_syms.py"
568 569
569 dump_syms_label = "//breakpad:dump_syms" 570 dump_syms_label = "//breakpad:dump_syms"
570 dump_syms_binary = 571 dump_syms_binary =
571 get_label_info(dump_syms_label, "root_out_dir") + "/" + "dump_syms" 572 get_label_info(dump_syms_label, "root_out_dir") + "/" + "dump_syms"
572 573
573 engine_binary = "$root_out_dir/blimp_engine_app" 574 engine_binary = "$root_out_dir/blimp_engine_app"
574 symbol_file = "$root_out_dir/blimp_engine_app.breakpad.x64" 575 symbol_file = "$root_out_dir/blimp_engine_app.breakpad.x64"
575 576
576 inputs = [ 577 inputs = [
577 engine_binary, 578 engine_binary,
578 dump_syms_binary, 579 dump_syms_binary,
579 ] 580 ]
580 outputs = [ 581 outputs = [
581 symbol_file, 582 symbol_file,
582 ] 583 ]
583 584
584 args = [ 585 args = [
585 "./" + rebase_path(dump_syms_binary, root_build_dir), 586 "./" + rebase_path(dump_syms_binary, root_build_dir),
586 "0", # strip_binary = false 587 "0", # strip_binary = false
587 rebase_path(engine_binary, root_build_dir), 588 rebase_path(engine_binary, root_build_dir),
588 rebase_path(symbol_file, root_build_dir), 589 rebase_path(symbol_file, root_build_dir),
589 ] 590 ]
590 591
592 # Include symupload target here as it is needed by the buildbots to upload
593 # the symbol file created by dump_syms.
591 deps = [ 594 deps = [
592 ":blimp_engine_app", 595 ":blimp_engine_app",
596 "//breakpad:symupload",
593 dump_syms_label, 597 dump_syms_label,
594 ] 598 ]
595 } 599 }
596 } 600 }
597 } 601 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698