Include symupload in official Blimp engine builds

blimp/engine/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/features.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/ui.gni")
 import("//mojo/public/tools/bindings/mojom.gni")
 import("//tools/grit/repack.gni")
@@ skipping 542 matching lines @@
       _rebased_dockerfile,
       "--startup-script",
       _rebased_startup_script,
       "--manifest",
       _rebased_manifest,
       "--output",
       rebase_path(_bundle),
     ]
   }
 
-  # Creates a breakpad symbol file for the engine. This takes a long time so
-  # it should only be done as part of the official build.
+  # Crash symbols should only be created and uploaded from official builders.
   if (is_official_build) {
+    # Action to create a breakpad symbol file for the engine. This can take

[Kevin M, 2016/05/18 20:31:46]

Capitalize: Breakpad, Engine

[marcinjb, 2016/05/18 20:42:04]

Done.

+    # a long time.
     action("blimp_symbols") {
       script = "//build/linux/dump_app_syms.py"
 
       dump_syms_label = "//breakpad:dump_syms"
       dump_syms_binary =
           get_label_info(dump_syms_label, "root_out_dir") + "/" + "dump_syms"
 
       engine_binary = "$root_out_dir/blimp_engine_app"
       symbol_file = "$root_out_dir/blimp_engine_app.breakpad.x64"
 
@@ skipping 10 matching lines @@
         "0",  # strip_binary = false
         rebase_path(engine_binary, root_build_dir),
         rebase_path(symbol_file, root_build_dir),
       ]
 
       deps = [
         ":blimp_engine_app",
         dump_syms_label,
       ]
     }
+
+    # Binary used by the buildbots to upload breakpad symbols.

[Kevin M, 2016/05/18 20:31:46]

THis isn't a binary, just a dep list.

Any reason why we can't just add this to blimp_symbols' deps list? It looks like
we never reference blimp_symbols and symupload separately.

[marcinjb, 2016/05/18 20:42:04]

Well, with a level of indirection, symupload generates a binary.  I was going to
try to keep these separate, but you're right, one goes with the other, so I've
collapsed it.

+    group("symupload") {
+      deps = [
+        "//breakpad:symupload",
+      ]
+    }
   }
 }