Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: blimp/engine/BUILD.gn

Issue 1987393002: Include symupload in official Blimp engine builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move symupload dep into the blimp_symbols target Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/BUILD.gn
diff --git a/blimp/engine/BUILD.gn b/blimp/engine/BUILD.gn
index 9abf44690ffc4f682dd0313da9ab2e6dc0ce1cb4..5841c86ad43837727461eb11231b4e5ddb8dd693 100644
--- a/blimp/engine/BUILD.gn
+++ b/blimp/engine/BUILD.gn
@@ -560,9 +560,10 @@ if (is_linux) {
]
}
- # Creates a breakpad symbol file for the engine. This takes a long time so
- # it should only be done as part of the official build.
+ # Crash symbols should only be created and uploaded from official builders.
if (is_official_build) {
+ # Action to create a Breakpad symbol file for the Engine. This can take
+ # a long time.
action("blimp_symbols") {
script = "//build/linux/dump_app_syms.py"
@@ -588,8 +589,11 @@ if (is_linux) {
rebase_path(symbol_file, root_build_dir),
]
+ # Include symupload target here as it is needed by the buildbots to upload
+ # the symbol file created by dump_syms.
deps = [
":blimp_engine_app",
+ "//breakpad:symupload",
dump_syms_label,
]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698