Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1984593002: Remove OwnPtr::release() calls in web/ & wtf/. (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
*tkent, *tzik
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-wtf_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, Mikhail, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OwnPtr::release() calls in web/ & wtf/. OwnPtr::release() calls can be (1) replaced with std::move(), or (2) removed entirely (in certain "return" statements). BUG=611660 Committed: https://crrev.com/76456ed6161751fd3ec1d5c8cbc752487cf12395 Cr-Commit-Position: refs/heads/master@{#394080}

Patch Set 1 #

Patch Set 2 : Merge with trunk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebBlob.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/DequeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/VectorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/TextPosition.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984593002/1
4 years, 7 months ago (2016-05-16 07:11:01 UTC) #2
Yuta Kitamura
tzik: PTAL? +tkent for web/ approval.
4 years, 7 months ago (2016-05-16 07:11:49 UTC) #5
tkent
lgtm
4 years, 7 months ago (2016-05-16 07:18:40 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-16 08:48:49 UTC) #8
tzik
lgtm
4 years, 7 months ago (2016-05-17 05:00:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984593002/1
4 years, 7 months ago (2016-05-17 05:15:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/184284)
4 years, 7 months ago (2016-05-17 05:21:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984593002/20001
4 years, 7 months ago (2016-05-17 06:30:27 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-17 08:07:11 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 08:09:03 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76456ed6161751fd3ec1d5c8cbc752487cf12395
Cr-Commit-Position: refs/heads/master@{#394080}

Powered by Google App Engine
This is Rietveld 408576698