Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Side by Side Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 1984593002: Remove OwnPtr::release() calls in web/ & wtf/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with trunk. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 { 117 {
118 s_instance = nullptr; 118 s_instance = nullptr;
119 } 119 }
120 120
121 static void ensureMainThreadDebuggerCreated(WebDevToolsAgentClient* client) 121 static void ensureMainThreadDebuggerCreated(WebDevToolsAgentClient* client)
122 { 122 {
123 if (s_instance) 123 if (s_instance)
124 return; 124 return;
125 OwnPtr<ClientMessageLoopAdapter> instance = adoptPtr(new ClientMessageLo opAdapter(adoptPtr(client->createClientMessageLoop()))); 125 OwnPtr<ClientMessageLoopAdapter> instance = adoptPtr(new ClientMessageLo opAdapter(adoptPtr(client->createClientMessageLoop())));
126 s_instance = instance.get(); 126 s_instance = instance.get();
127 MainThreadDebugger::instance()->setClientMessageLoop(instance.release()) ; 127 MainThreadDebugger::instance()->setClientMessageLoop(std::move(instance) );
128 } 128 }
129 129
130 static void webViewImplClosed(WebViewImpl* view) 130 static void webViewImplClosed(WebViewImpl* view)
131 { 131 {
132 if (s_instance) 132 if (s_instance)
133 s_instance->m_frozenViews.remove(view); 133 s_instance->m_frozenViews.remove(view);
134 } 134 }
135 135
136 static void webFrameWidgetImplClosed(WebFrameWidgetImpl* widget) 136 static void webFrameWidgetImplClosed(WebFrameWidgetImpl* widget)
137 { 137 {
(...skipping 553 matching lines...) Expand 10 before | Expand all | Expand 10 after
691 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method) 691 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method)
692 { 692 {
693 return method == "Debugger.pause" 693 return method == "Debugger.pause"
694 || method == "Debugger.setBreakpoint" 694 || method == "Debugger.setBreakpoint"
695 || method == "Debugger.setBreakpointByUrl" 695 || method == "Debugger.setBreakpointByUrl"
696 || method == "Debugger.removeBreakpoint" 696 || method == "Debugger.removeBreakpoint"
697 || method == "Debugger.setBreakpointsActive"; 697 || method == "Debugger.setBreakpointsActive";
698 } 698 }
699 699
700 } // namespace blink 700 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebBlob.cpp ('k') | third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698