Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 1984593002: Remove OwnPtr::release() calls in web/ & wtf/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with trunk. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index 8514db7e63209dec68996035297a1ab9b8362ccb..20bda206f85e408994f4ce00e6f1956d7b05e08a 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -402,7 +402,7 @@ static PassOwnPtr<protocol::DictionaryValue> buildObjectForSize(const IntSize& s
OwnPtr<protocol::DictionaryValue> result = protocol::DictionaryValue::create();
result->setNumber("width", size.width());
result->setNumber("height", size.height());
- return result.release();
+ return result;
}
void InspectorOverlay::drawNodeHighlight()
@@ -423,7 +423,7 @@ void InspectorOverlay::drawNodeHighlight()
Element* element = elements->item(i);
InspectorHighlight highlight(element, m_nodeHighlightConfig, false);
OwnPtr<protocol::DictionaryValue> highlightJSON = highlight.asProtocolValue();
- evaluateInOverlay("drawHighlight", highlightJSON.release());
+ evaluateInOverlay("drawHighlight", std::move(highlightJSON));
}
}
@@ -433,7 +433,7 @@ void InspectorOverlay::drawNodeHighlight()
highlight.appendEventTargetQuads(m_eventTargetNode.get(), m_nodeHighlightConfig);
OwnPtr<protocol::DictionaryValue> highlightJSON = highlight.asProtocolValue();
- evaluateInOverlay("drawHighlight", highlightJSON.release());
+ evaluateInOverlay("drawHighlight", std::move(highlightJSON));
}
void InspectorOverlay::drawQuadHighlight()
@@ -536,7 +536,7 @@ void InspectorOverlay::reset(const IntSize& viewportSize, const IntPoint& docume
resetData->setNumber("pageZoomFactor", m_webViewImpl->mainFrameImpl()->frame()->pageZoomFactor());
resetData->setNumber("scrollX", documentScrollOffset.x());
resetData->setNumber("scrollY", documentScrollOffset.y());
- evaluateInOverlay("reset", resetData.release());
+ evaluateInOverlay("reset", std::move(resetData));
}
void InspectorOverlay::evaluateInOverlay(const String& method, const String& argument)
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698