third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp - Issue 1984593002: Remove OwnPtr::release() calls in web/ & wtf/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp

Issue 1984593002: Remove OwnPtr::release() calls in web/ & wtf/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with trunk. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp b/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp

index f87ad10ce6c10cbd344b5a548ea45b19699e1489..42e7c9e1e71d5b671af71da152884c9a2c583f06 100644

--- a/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp

+++ b/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp

@@ -149,7 +149,7 @@ void SharedWorkerRepositoryClientImpl::connect(SharedWorker* worker, PassOwnPtr<

// The connector object manages its own lifecycle (and the lifecycles of the two worker objects).

// It will free itself once connecting is completed.

- SharedWorkerConnector* connector = new SharedWorkerConnector(worker, url, name, std::move(port), webWorkerConnector.release());

+ SharedWorkerConnector* connector = new SharedWorkerConnector(worker, url, name, std::move(port), std::move(webWorkerConnector));

connector->connect();

}