DescriptionRevert of cc: nine patch: add occlusion support (patchset #10 id:180001 of https://codereview.chromium.org/1889153002/ )
Reason for revert:
Shadow are broken on HiDPI monitors. See https://bugs.chromium.org/p/chromium/issues/detail?id=607033
More people are noticing this and the fix is not ready yet.
Let's revert this for now.
Original issue's description:
> cc: nine patch: add occlusion support
>
> When using a NinePatchLayer to draw shadows on windows on ChromeOS part of
> patches which are completely transparent are drawn on top of the window.
> This prevents for example videos to be promoted into layers.
>
> This patch introduce an optional property on the NinePatchLayer :
> layer_occlusion. When this property is set, we can use it to compute 12
> patches to paint the shadow rather than 8 (center omitted). This prevents
> drawing on the window's content completely and allows layer promotion
> algorithms to promote the windows's content as layer if possible (in
> particular with videos).
>
> BUG=603866
> TEST=cc_unittests --gtest_filter=NinePatchLayer*
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/8b134c7492731333fabeda5e358f0604ae5f565e
> Cr-Commit-Position: refs/heads/master@{#389770}
TBR=aelias@chromium.org,danakj@chromium.org,derat@chromium.org,hshi@chromium.org,msw@chromium.org,sky@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=603866
Committed: https://crrev.com/eec4f7be5b4843419b6eefe0fdf1b65cee774bc1
Cr-Commit-Position: refs/heads/master@{#393881}
Patch Set 1 #
Messages
Total messages: 10 (2 generated)
|