Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1983803003: Revert of cc: nine patch: add occlusion support (Closed)

Created:
4 years, 7 months ago by llandwerlin-old
Modified:
4 years, 7 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, jbauman+watch_chromium.org, kalyank, msw, piman+watch_chromium.org, sadrul, sievers+watch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: nine patch: add occlusion support (patchset #10 id:180001 of https://codereview.chromium.org/1889153002/ ) Reason for revert: Shadow are broken on HiDPI monitors. See https://bugs.chromium.org/p/chromium/issues/detail?id=607033 More people are noticing this and the fix is not ready yet. Let's revert this for now. Original issue's description: > cc: nine patch: add occlusion support > > When using a NinePatchLayer to draw shadows on windows on ChromeOS part of > patches which are completely transparent are drawn on top of the window. > This prevents for example videos to be promoted into layers. > > This patch introduce an optional property on the NinePatchLayer : > layer_occlusion. When this property is set, we can use it to compute 12 > patches to paint the shadow rather than 8 (center omitted). This prevents > drawing on the window's content completely and allows layer promotion > algorithms to promote the windows's content as layer if possible (in > particular with videos). > > BUG=603866 > TEST=cc_unittests --gtest_filter=NinePatchLayer* > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/8b134c7492731333fabeda5e358f0604ae5f565e > Cr-Commit-Position: refs/heads/master@{#389770} TBR=aelias@chromium.org,danakj@chromium.org,derat@chromium.org,hshi@chromium.org,msw@chromium.org,sky@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603866 Committed: https://crrev.com/eec4f7be5b4843419b6eefe0fdf1b65cee774bc1 Cr-Commit-Position: refs/heads/master@{#393881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -368 lines) Patch
M cc/layers/nine_patch_layer.h View 2 chunks +0 lines, -9 lines 0 comments Download
M cc/layers/nine_patch_layer.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M cc/layers/nine_patch_layer_impl.h View 3 chunks +15 lines, -51 lines 0 comments Download
M cc/layers/nine_patch_layer_impl.cc View 7 chunks +242 lines, -230 lines 0 comments Download
M cc/layers/nine_patch_layer_impl_unittest.cc View 13 chunks +57 lines, -57 lines 0 comments Download
M mash/wm/shadow.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/layer.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/compositor/layer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/wm/core/shadow.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
llandwerlin-old
Created Revert of cc: nine patch: add occlusion support
4 years, 7 months ago (2016-05-16 17:16:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983803003/1
4 years, 7 months ago (2016-05-16 17:17:00 UTC) #2
Daniel Erat
lgtm
4 years, 7 months ago (2016-05-16 17:26:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983803003/1
4 years, 7 months ago (2016-05-16 17:31:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983803003/1
4 years, 7 months ago (2016-05-16 18:01:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983803003/1
4 years, 7 months ago (2016-05-16 18:31:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 18:46:58 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 18:48:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eec4f7be5b4843419b6eefe0fdf1b65cee774bc1
Cr-Commit-Position: refs/heads/master@{#393881}

Powered by Google App Engine
This is Rietveld 408576698