Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1980763002: ApplicationConnection devolution, part 2.3. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work794_app_conn_devo_2.2
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

ApplicationConnection devolution, part 2.3. A.k.a. nuke InterfaceFactory, part 3. I also noticed that I previously forgot to call AddService() in tracing_app.cc. R=vardhan@google.com BUG=probably has something to do with #775 and #776 (may fix them) Committed: https://chromium.googlesource.com/external/mojo/+/5e30a0746ec1ff2b2a7303a38acdc736b10c83fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -264 lines) Patch
M mojo/public/cpp/bindings/binding.h View 1 chunk +0 lines, -9 lines 0 comments Download
M mojo/public/cpp/bindings/strong_binding.h View 1 chunk +0 lines, -8 lines 0 comments Download
M services/keyboard/linux/keyboard_service_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/native_viewport/native_viewport_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/test_service/test_request_tracker_application.h View 3 chunks +1 line, -18 lines 0 comments Download
M services/test_service/test_request_tracker_application.cc View 1 chunk +15 lines, -21 lines 0 comments Download
M services/test_service/test_service_application.h View 3 chunks +1 line, -12 lines 0 comments Download
M services/test_service/test_service_application.cc View 1 chunk +11 lines, -13 lines 0 comments Download
M services/tracing/tracing_app.h View 2 chunks +0 lines, -10 lines 0 comments Download
M services/tracing/tracing_app.cc View 1 chunk +17 lines, -16 lines 0 comments Download
M services/ui/input_manager/input_manager_app.h View 2 chunks +2 lines, -8 lines 0 comments Download
M services/ui/input_manager/input_manager_app.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M services/ui/launcher/launcher_app.h View 2 chunks +1 line, -7 lines 0 comments Download
M services/ui/launcher/launcher_app.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M services/ui/view_manager/view_manager_app.h View 2 chunks +1 line, -6 lines 0 comments Download
M services/ui/view_manager/view_manager_app.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_app.h View 2 chunks +1 line, -7 lines 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_app.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M shell/android/native_viewport_application_loader.h View 3 chunks +2 lines, -14 lines 0 comments Download
M shell/android/native_viewport_application_loader.cc View 1 chunk +15 lines, -19 lines 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 6 chunks +24 lines, -33 lines 0 comments Download
M shell/test/pingable_app.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M ui/ozone/platform/drm/mojo/drm_ipc_init_helper.cc View 2 chunks +10 lines, -20 lines 0 comments Download

Depends on Patchset:

Issue 1981513002 Patch 1

Dependent Patchsets:

Issue 1979683002 Patch 1
Issue 1979683002 Patch 20001

Messages

Total messages: 4 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/1981513002/.
4 years, 7 months ago (2016-05-13 20:06:41 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-13 20:38:03 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-13 21:13:05 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5e30a0746ec1ff2b2a7303a38acdc736b10c83fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698