Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1981513002: ApplicationConnection devolution, part 2.2. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

ApplicationConnection devolution, part 2.2. A.k.a. nuke InterfaceFactory, part 2. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/688f68eedbdac924d29c4e77aa9597cb063fd47a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -257 lines) Patch
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.h View 2 chunks +1 line, -9 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M services/authentication/main.cc View 3 chunks +15 lines, -19 lines 0 comments Download
M services/clipboard/main.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M services/device_info/device_info.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M services/files/main.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M services/gfx/compositor/compositor_app.h View 2 chunks +1 line, -9 lines 0 comments Download
M services/gfx/compositor/compositor_app.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M services/http_server/http_server_app.cc View 2 chunks +9 lines, -14 lines 0 comments Download
M services/icu_data/icu_data_impl.cc View 2 chunks +7 lines, -11 lines 0 comments Download
M services/keyboard/linux/main.cc View 4 chunks +8 lines, -13 lines 0 comments Download
M services/log/main.cc View 3 chunks +9 lines, -13 lines 0 comments Download
M services/media/audio/audio_server_app.h View 3 chunks +1 line, -7 lines 0 comments Download
M services/media/audio/audio_server_app.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M services/media/factory_service/factory_service.h View 2 chunks +0 lines, -5 lines 0 comments Download
M services/media/factory_service/factory_service.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M services/nacl/nonsfi/pnacl_compile.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M services/nacl/nonsfi/pnacl_link.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M services/native_support/main.cc View 3 chunks +10 lines, -14 lines 0 comments Download
M services/native_viewport/app_delegate.h View 2 chunks +1 line, -12 lines 0 comments Download
M services/native_viewport/app_delegate.cc View 2 chunks +18 lines, -19 lines 0 comments Download
M services/prediction/prediction_service_impl.h View 3 chunks +4 lines, -7 lines 0 comments Download
M services/prediction/prediction_service_impl.cc View 3 chunks +9 lines, -18 lines 0 comments Download

Dependent Patchsets:

Issue 1980763002 Patch 1

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-13 19:25:25 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-13 20:37:56 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-13 21:12:10 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
688f68eedbdac924d29c4e77aa9597cb063fd47a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698