Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1979683002: ApplicationConnection devolution, part 2.4. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work795_app_conn_devo_2.3-x-work794_app_conn_devo_2.2
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

ApplicationConnection devolution, part 2.4. A.k.a. nuke InterfaceFactory, part 4. I took care of ContentHandlerFactory in a way that seems OK, but may not be optimal design-wise (to be considered later -- I'll actually need to think about its design). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2b9bfa7f95a3a0b6f10edd3cac33ae40587b7bbc

Patch Set 1 #

Patch Set 2 : so much doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -27 lines) Patch
M examples/forwarding_content_handler/forwarding_content_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M examples/recursive_content_handler/recursive_content_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/application/content_handler_factory.h View 2 chunks +13 lines, -6 lines 0 comments Download
M mojo/application/content_handler_factory.cc View 2 chunks +14 lines, -7 lines 0 comments Download
M services/dart/content_handler_main.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M services/java_handler/java_handler.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M services/js/content_handler_main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/nacl/nonsfi/content_handler_main_nexe.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/nacl/nonsfi/content_handler_main_pexe.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/nacl/sfi/content_handler_main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/python/content_handler/content_handler_main.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M shell/android/android_handler.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/1980763002/.
4 years, 7 months ago (2016-05-13 20:28:36 UTC) #1
vardhan
seems like build fails on android
4 years, 7 months ago (2016-05-13 20:39:59 UTC) #2
viettrungluu
On 2016/05/13 20:39:59, vardhan wrote: > seems like build fails on android Gah, should be ...
4 years, 7 months ago (2016-05-13 21:11:42 UTC) #3
vardhan
lgtm
4 years, 7 months ago (2016-05-13 21:24:23 UTC) #4
viettrungluu
4 years, 7 months ago (2016-05-13 21:25:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2b9bfa7f95a3a0b6f10edd3cac33ae40587b7bbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698