Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: mojo/application/content_handler_factory.h

Issue 1979683002: ApplicationConnection devolution, part 2.4. (Closed) Base URL: https://github.com/domokit/mojo.git@work795_app_conn_devo_2.3-x-work794_app_conn_devo_2.2
Patch Set: so much doh Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/application/content_handler_factory.h
diff --git a/mojo/application/content_handler_factory.h b/mojo/application/content_handler_factory.h
index 0d1d3e94ea5155a48fb23c2e6e863ed0ac724aba..86293dfe4c73ea3bd7d346b9b4b41f60e34caaee 100644
--- a/mojo/application/content_handler_factory.h
+++ b/mojo/application/content_handler_factory.h
@@ -6,14 +6,17 @@
#define MOJO_APPLICATION_CONTENT_HANDLER_FACTORY_H_
#include "base/memory/scoped_ptr.h"
-#include "mojo/public/cpp/application/interface_factory.h"
+#include "mojo/public/cpp/application/service_provider_impl.h"
#include "mojo/public/interfaces/application/shell.mojom.h"
#include "mojo/services/content_handler/interfaces/content_handler.mojom.h"
#include "mojo/services/network/interfaces/url_loader.mojom.h"
namespace mojo {
-class ContentHandlerFactory : public InterfaceFactory<ContentHandler> {
+struct ConnectionContext;
+
+// TODO(vtl): Should this even be a class, now that InterfaceFactory is no more?
+class ContentHandlerFactory {
public:
class HandledApplicationHolder {
public:
@@ -47,13 +50,17 @@ class ContentHandlerFactory : public InterfaceFactory<ContentHandler> {
};
explicit ContentHandlerFactory(Delegate* delegate);
- ~ContentHandlerFactory() override;
+ ~ContentHandlerFactory();
- private:
- // From InterfaceFactory:
+ // Creates a content handler for the given connection (context and request).
void Create(const ConnectionContext& connection_context,
- InterfaceRequest<ContentHandler> request) override;
+ InterfaceRequest<ContentHandler> content_handler_request);
+ // For use with |ServiceProviderImpl::AddService<ContentHandler>()|.
+ ServiceProviderImpl::InterfaceRequestHandler<ContentHandler>
+ GetInterfaceRequestHandler();
+
+ private:
Delegate* delegate_;
DISALLOW_COPY_AND_ASSIGN(ContentHandlerFactory);
« no previous file with comments | « examples/recursive_content_handler/recursive_content_handler.cc ('k') | mojo/application/content_handler_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698