Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1977123002: ApplicationConnection devolution, part 2.5. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work790_app_conn_devo_2.4
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

ApplicationConnection devolution, part 2.5. A.k.a. nuke InterfaceFactory, part 5 (the last one of this series). InterfaceFactory is now gone (and so is InterfaceFactoryConnector). And the pointlessness of ApplicationConnection is now totally obvious. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/beec2bcc859d393846443860218f842362141f39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -106 lines) Patch
M mojo/public/cpp/application/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/application_connection.h View 1 chunk +0 lines, -34 lines 0 comments Download
M mojo/public/cpp/application/application_impl.h View 1 chunk +4 lines, -5 lines 0 comments Download
D mojo/public/cpp/application/interface_factory.h View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/public/cpp/application/lib/interface_factory_connector.h View 1 chunk +0 lines, -37 lines 0 comments Download

Depends on Patchset:

Issue 1979683002 Patch 20001

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-13 21:25:02 UTC) #1
viettrungluu
(Ignore the failed try results. The git mirror needs to catch up.)
4 years, 7 months ago (2016-05-13 21:37:38 UTC) #2
vardhan
lgtm hm, it's only fusl tests (under linux) that fail..
4 years, 7 months ago (2016-05-13 21:50:18 UTC) #3
viettrungluu
4 years, 7 months ago (2016-05-13 22:00:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
beec2bcc859d393846443860218f842362141f39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698