Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1979493002: Remove OwnPtr::release() calls in bindings/. (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
*haraken, tzik
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OwnPtr::release() calls in bindings/. They can now be replaced with std::move() call. BUG=611660 Committed: https://crrev.com/877198eff9d5b0ebd91bb6de2013fe2503e403b8 Cr-Commit-Position: refs/heads/master@{#393486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979493002/1
4 years, 7 months ago (2016-05-13 06:59:56 UTC) #2
Yuta Kitamura
haraken: PTAL? tzik: FYI.
4 years, 7 months ago (2016-05-13 07:29:24 UTC) #5
haraken
LGTM
4 years, 7 months ago (2016-05-13 07:32:02 UTC) #6
tzik
lgtm
4 years, 7 months ago (2016-05-13 09:03:28 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 09:06:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979493002/1
4 years, 7 months ago (2016-05-13 09:13:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 09:16:20 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 09:17:49 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/877198eff9d5b0ebd91bb6de2013fe2503e403b8
Cr-Commit-Position: refs/heads/master@{#393486}

Powered by Google App Engine
This is Rietveld 408576698