third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp - Issue 1979493002: Remove OwnPtr::release() calls in bindings/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp

Issue 1979493002: Remove OwnPtr::release() calls in bindings/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp

index 46239ccc3cb3497a0be47931f586b6bb7927fc05..90c0ebde9e08a64ee672a3b9a1790785ab8ca766 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp

@@ -58,7 +58,7 @@ PassRefPtr<ScriptCallStack> ScriptCallStack::capture(size_t maxStackSize)

return nullptr;

ScriptForbiddenScope::AllowUserAgentScript allowScripting;

OwnPtr<V8StackTrace> stack = data->threadDebugger()->debugger()->captureStackTrace(maxStackSize);

- return stack ? adoptRef(new ScriptCallStack(stack.release())) : nullptr;

+ return stack ? adoptRef(new ScriptCallStack(std::move(stack))) : nullptr;

}

PassRefPtr<ScriptCallStack> ScriptCallStack::captureForConsole()