third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp - Issue 1979493002: Remove OwnPtr::release() calls in bindings/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

Issue 1979493002: Remove OwnPtr::release() calls in bindings/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

index 33618aad2089901c3eadb683f240021af98a6a80..ee875d9c33097ee233ea24fd56210b02658e1a53 100644

--- a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

@@ -220,7 +220,7 @@ void RejectedPromises::handlerAdded(v8::PromiseRejectMessage data)

OwnPtr<Message>& message = m_reportedAsErrors.at(i);

if (!message->isCollected() && message->hasPromise(data.GetPromise())) {

message->makePromiseStrong();

- Platform::current()->currentThread()->scheduler()->timerTaskRunner()->postTask(BLINK_FROM_HERE, bind(&RejectedPromises::revokeNow, this, passed(message.release())));

+ Platform::current()->currentThread()->scheduler()->timerTaskRunner()->postTask(BLINK_FROM_HERE, bind(&RejectedPromises::revokeNow, this, passed(std::move(message))));

m_reportedAsErrors.remove(i);

return;

}

@@ -239,7 +239,7 @@ void RejectedPromises::dispose()

OwnPtr<MessageQueue> queue = createMessageQueue();

queue->swap(m_queue);

- processQueueNow(queue.release());

+ processQueueNow(std::move(queue));

}

void RejectedPromises::processQueue()

@@ -249,7 +249,7 @@ void RejectedPromises::processQueue()

OwnPtr<MessageQueue> queue = createMessageQueue();

queue->swap(m_queue);

- Platform::current()->currentThread()->scheduler()->timerTaskRunner()->postTask(BLINK_FROM_HERE, bind(&RejectedPromises::processQueueNow, PassRefPtr<RejectedPromises>(this), passed(queue.release())));

+ Platform::current()->currentThread()->scheduler()->timerTaskRunner()->postTask(BLINK_FROM_HERE, bind(&RejectedPromises::processQueueNow, PassRefPtr<RejectedPromises>(this), passed(std::move(queue))));

}

void RejectedPromises::processQueueNow(PassOwnPtr<MessageQueue> queue)

@@ -269,7 +269,7 @@ void RejectedPromises::processQueueNow(PassOwnPtr<MessageQueue> queue)

if (!message->hasHandler()) {

message->report();

message->makePromiseWeak();

- m_reportedAsErrors.append(message.release());

+ m_reportedAsErrors.append(std::move(message));

if (m_reportedAsErrors.size() > maxReportedHandlersPendingResolution)

m_reportedAsErrors.remove(0, maxReportedHandlersPendingResolution / 10);

}