third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp - Issue 1979493002: Remove OwnPtr::release() calls in bindings/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

Issue 1979493002: Remove OwnPtr::release() calls in bindings/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

index edd1331b6f42b7a476970328a4ec08930f6ebee9..ad130a9e4b444cafd3e817d62f5d9eb2cb7784c9 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

@@ -147,7 +147,7 @@ v8::Local<v8::Object> ScriptPromisePropertyBase::ensureHolderWrapper(ScriptState

OwnPtr<ScopedPersistent<v8::Object>> weakPersistent = adoptPtr(new ScopedPersistent<v8::Object>);

weakPersistent->set(m_isolate, wrapper);

weakPersistent->setWeak(weakPersistent.get(), &clearHandle);

- m_wrappers.append(weakPersistent.release());

+ m_wrappers.append(std::move(weakPersistent));

return wrapper;

}