Add DBus plumbing and tests for sending devices with ATT read/writes.

Add DBus plumbing and tests for sending devices with ATT read/writes.

This CL adds the plumbing needed to pass on the device that is read from
DBus to the //device/bluetooth delegate. This also allows us to add tests
that check the device on read/write requests to attribute values.

Reviews requested,
xiyuan@ - General review.
scheib@ - Test changes owners review.

R=scheib@chromium.org, xiyuan@chromium.org
BUG=611862
Committed: https://crrev.com/4a98d82baaf2f5f5c2d9b09a2468e3ceff565790
Cr-Commit-Position: refs/heads/master@{#394254}

[rkc, 2016-05-16 03:30:45]

This CL doesn't contain any code that actually reads the device information from
DBus. That code will depend on BlueZ changes landed, so I'll be sending them out
in a separate CL.

[xiyuan, 2016-05-16 21:27:07]

https://codereview.chromium.org/1979163002/diff/1/device/bluetooth/dbus/bluet...
File device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h (right):

https://codereview.chromium.org/1979163002/diff/1/device/bluetooth/dbus/bluet...
device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h:75:
BluetoothLocalGattServiceBlueZ* service_;
Having a data member in an interface looks strange. Why promoting this from
derived classes?

[rkc, 2016-05-16 21:44:29]

https://codereview.chromium.org/1979163002/diff/1/device/bluetooth/dbus/bluet...
File device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h (right):

https://codereview.chromium.org/1979163002/diff/1/device/bluetooth/dbus/bluet...
device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h:75:
BluetoothLocalGattServiceBlueZ* service_;
On 2016/05/16 21:27:07, xiyuan wrote:
> Having a data member in an interface looks strange. Why promoting this from
> derived classes?

It is needed by the derived classes + this class. Forgot to upload the .cc for
this class, this isn't an interface anymore but a base class.

Uploaded.

[xiyuan, 2016-05-16 22:05:01]

lgtm

https://codereview.chromium.org/1979163002/diff/1/device/bluetooth/dbus/bluet...
File device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h (right):

https://codereview.chromium.org/1979163002/diff/1/device/bluetooth/dbus/bluet...
device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h:75:
BluetoothLocalGattServiceBlueZ* service_;
On 2016/05/16 21:44:29, Rahul Chaturvedi wrote:
> On 2016/05/16 21:27:07, xiyuan wrote:
> > Having a data member in an interface looks strange. Why promoting this from
> > derived classes?
> 
> It is needed by the derived classes + this class. Forgot to upload the .cc for
> this class, this isn't an interface anymore but a base class.
> 
> Uploaded.

Acknowledged.

https://codereview.chromium.org/1979163002/diff/20001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h (right):

https://codereview.chromium.org/1979163002/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h:13: #include
"device/bluetooth/bluetooth_device.h"
nit: move the headers to cc and forward decalre ObjectPath and BluetoothDevice

https://codereview.chromium.org/1979163002/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h:75:
BluetoothLocalGattServiceBlueZ* service_;
nit: const ptr since |service_| would not change for the lifetime of the object.

i.e.
BluetoothLocalGattServiceBlueZ const* service_;

https://codereview.chromium.org/1979163002/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h:76: };
nit: DISALLOW_COPY_AND_ASSIGN(...)

[rkc, 2016-05-16 23:19:06]

https://codereview.chromium.org/1979163002/diff/20001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h (right):

https://codereview.chromium.org/1979163002/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h:13: #include
"device/bluetooth/bluetooth_device.h"
On 2016/05/16 22:05:00, xiyuan wrote:
> nit: move the headers to cc and forward decalre ObjectPath and BluetoothDevice

Done.

https://codereview.chromium.org/1979163002/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h:75:
BluetoothLocalGattServiceBlueZ* service_;
On 2016/05/16 22:05:00, xiyuan wrote:
> nit: const ptr since |service_| would not change for the lifetime of the
object.
> 
> i.e.
> BluetoothLocalGattServiceBlueZ const* service_;

Done.

https://codereview.chromium.org/1979163002/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_gatt_attribute_value_delegate.h:76: };
On 2016/05/16 22:05:00, xiyuan wrote:
> nit: DISALLOW_COPY_AND_ASSIGN(...)

Done.

[rkc, 2016-05-17 05:30:15]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 05:30:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979163002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979163002/60001

[commit-bot: I haz the power, 2016-05-17 05:47:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 05:47:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rkc, 2016-05-17 08:12:20]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[rkc, 2016-05-17 08:12:28]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 08:12:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979163002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979163002/80001

[commit-bot: I haz the power, 2016-05-17 10:11:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 10:11:02]

Dry run: This issue passed the CQ dry run.

[rkc, 2016-05-17 16:28:30]

Ping? We're getting awfully close to the branch.

[scheib, 2016-05-17 19:58:18]

LGTM

[rkc, 2016-05-17 22:45:38]

The CQ bit was checked by rkc@chromium.org

[rkc, 2016-05-17 22:45:38]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1979163002/#ps80001
(title: "gyp fix")

[commit-bot: I haz the power, 2016-05-17 22:46:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979163002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979163002/80001

[commit-bot: I haz the power, 2016-05-17 22:52:24]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-17 22:55:17]

Description was changed from

==========
Add DBus plumbing and tests for sending devices with ATT read/writes.

This CL adds the plumbing needed to pass on the device that is read from
DBus to the //device/bluetooth delegate. This also allows us to add tests
that check the device on read/write requests to attribute values.


Reviews requested,
xiyuan@ - General review.
scheib@ - Test changes owners review.

R=scheib@chromium.org, xiyuan@chromium.org
BUG=611862
==========

to

==========
Add DBus plumbing and tests for sending devices with ATT read/writes.

This CL adds the plumbing needed to pass on the device that is read from
DBus to the //device/bluetooth delegate. This also allows us to add tests
that check the device on read/write requests to attribute values.

Reviews requested,
xiyuan@ - General review.
scheib@ - Test changes owners review.

R=scheib@chromium.org, xiyuan@chromium.org
BUG=611862

Committed: https://crrev.com/4a98d82baaf2f5f5c2d9b09a2468e3ceff565790
Cr-Commit-Position: refs/heads/master@{#394254}
==========

[commit-bot: I haz the power, 2016-05-17 22:55:19]

Patchset 5 (id:??) landed as
https://crrev.com/4a98d82baaf2f5f5c2d9b09a2468e3ceff565790
Cr-Commit-Position: refs/heads/master@{#394254}