Remove service, add device, in BluetoothLocalGattService::Delegate

Remove service, add device, in BluetoothLocalGattService::Delegate.

This Delegate sends the service along with the local GATT attributes when
there really is no reason to send the service along. If a client needs the
service, they can just get it from the attribute they are handling.

However, we *are* missing the device, which is needed by clients to identify
which device is actually making the read/write/notifystate requests.

BluetoothLocalGattCharacteristicBlueZ::NotifyValueChanged now also
takes a device.

This CL fixes these issues and all current clients/tests for this code.

R=scheib@chromium.org
BUG=611862
Committed: https://crrev.com/d4ba1a590a3fcfee93f76ed4eb5d02235c4c8ad8
Cr-Commit-Position: refs/heads/master@{#394251}

[rkc, 2016-05-17 05:30:09]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 05:30:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973343005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973343005/60001

[commit-bot: I haz the power, 2016-05-17 07:33:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 07:33:20]

Dry run: This issue passed the CQ dry run.

[rkc, 2016-05-17 16:28:22]

Ping? We're getting awfully close to the branch.

[scheib, 2016-05-17 19:43:51]

Description was changed from

==========
Fix BluetoothLocalGattService::Delegate.

This Delegate sends the service along with the local GATT attirbutes when
there really is no reason to send the service along. If a client needs the
service, they can just get it from the attribute they are handling.

However, we *are* missing the device, which is needed by clients to identify
which device is actually making the read/write/notifystate requests.

This CL fixes these issues and all current clients/tests for this code.

R=scheib@chromium.org
BUG=611862
==========

to

==========
Remove service, add device, in BluetoothLocalGattService::Delegate.

This Delegate sends the service along with the local GATT attributes when
there really is no reason to send the service along. If a client needs the
service, they can just get it from the attribute they are handling.

However, we *are* missing the device, which is needed by clients to identify
which device is actually making the read/write/notifystate requests.

This CL fixes these issues and all current clients/tests for this code.

R=scheib@chromium.org
BUG=611862
==========

[scheib, 2016-05-17 19:53:34]

Description was changed from

==========
Remove service, add device, in BluetoothLocalGattService::Delegate.

This Delegate sends the service along with the local GATT attributes when
there really is no reason to send the service along. If a client needs the
service, they can just get it from the attribute they are handling.

However, we *are* missing the device, which is needed by clients to identify
which device is actually making the read/write/notifystate requests.

This CL fixes these issues and all current clients/tests for this code.

R=scheib@chromium.org
BUG=611862
==========

to

==========
Remove service, add device, in BluetoothLocalGattService::Delegate.

This Delegate sends the service along with the local GATT attributes when
there really is no reason to send the service along. If a client needs the
service, they can just get it from the attribute they are handling.

However, we *are* missing the device, which is needed by clients to identify
which device is actually making the read/write/notifystate requests.

BluetoothLocalGattCharacteristicBlueZ::NotifyValueChanged now also 
takes a device.

This CL fixes these issues and all current clients/tests for this code.

R=scheib@chromium.org
BUG=611862
==========

[scheib, 2016-05-17 19:54:27]

LGTM, with comment fix below.

Also, I've updated the description some to be more explicit.

https://codereview.chromium.org/1973343005/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_local_gatt_characteristic.h (right):

https://codereview.chromium.org/1973343005/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_local_gatt_characteristic.h:58: // Notify that the
remote device |device| that the value of characteristic
"Notify the remote"

[rkc, 2016-05-17 19:56:35]

https://codereview.chromium.org/1973343005/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_local_gatt_characteristic.h (right):

https://codereview.chromium.org/1973343005/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_local_gatt_characteristic.h:58: // Notify that the
remote device |device| that the value of characteristic
On 2016/05/17 19:54:27, scheib wrote:
> "Notify the remote"

Done.

[rkc, 2016-05-17 20:04:49]

The CQ bit was checked by rkc@chromium.org

[rkc, 2016-05-17 20:04:49]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1973343005/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-05-17 20:06:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973343005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973343005/80001

[commit-bot: I haz the power, 2016-05-17 22:42:44]

Description was changed from

==========
Remove service, add device, in BluetoothLocalGattService::Delegate.

This Delegate sends the service along with the local GATT attributes when
there really is no reason to send the service along. If a client needs the
service, they can just get it from the attribute they are handling.

However, we *are* missing the device, which is needed by clients to identify
which device is actually making the read/write/notifystate requests.

BluetoothLocalGattCharacteristicBlueZ::NotifyValueChanged now also 
takes a device.

This CL fixes these issues and all current clients/tests for this code.

R=scheib@chromium.org
BUG=611862
==========

to

==========
Remove service, add device, in BluetoothLocalGattService::Delegate.

This Delegate sends the service along with the local GATT attributes when
there really is no reason to send the service along. If a client needs the
service, they can just get it from the attribute they are handling.

However, we *are* missing the device, which is needed by clients to identify
which device is actually making the read/write/notifystate requests.

BluetoothLocalGattCharacteristicBlueZ::NotifyValueChanged now also 
takes a device.

This CL fixes these issues and all current clients/tests for this code.

R=scheib@chromium.org
BUG=611862
==========

[commit-bot: I haz the power, 2016-05-17 22:42:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-17 22:44:03]

Description was changed from

==========
Remove service, add device, in BluetoothLocalGattService::Delegate.

This Delegate sends the service along with the local GATT attributes when
there really is no reason to send the service along. If a client needs the
service, they can just get it from the attribute they are handling.

However, we *are* missing the device, which is needed by clients to identify
which device is actually making the read/write/notifystate requests.

BluetoothLocalGattCharacteristicBlueZ::NotifyValueChanged now also 
takes a device.

This CL fixes these issues and all current clients/tests for this code.

R=scheib@chromium.org
BUG=611862
==========

to

==========
Remove service, add device, in BluetoothLocalGattService::Delegate.

This Delegate sends the service along with the local GATT attributes when
there really is no reason to send the service along. If a client needs the
service, they can just get it from the attribute they are handling.

However, we *are* missing the device, which is needed by clients to identify
which device is actually making the read/write/notifystate requests.

BluetoothLocalGattCharacteristicBlueZ::NotifyValueChanged now also
takes a device.

This CL fixes these issues and all current clients/tests for this code.

R=scheib@chromium.org
BUG=611862

Committed: https://crrev.com/d4ba1a590a3fcfee93f76ed4eb5d02235c4c8ad8
Cr-Commit-Position: refs/heads/master@{#394251}
==========

[commit-bot: I haz the power, 2016-05-17 22:44:04]

Patchset 5 (id:??) landed as
https://crrev.com/d4ba1a590a3fcfee93f76ed4eb5d02235c4c8ad8
Cr-Commit-Position: refs/heads/master@{#394251}