Add implementation for parsing device info in read/write attribute calls.

Add implementation for parsing device info in read/write attribute calls.

This CL adds the actual DBus implementation for parsing the device information
from the options dictionaries now passed up from BlueZ with the GATT
attribute value read/write request calls. It also plumbs the device
information up to the Chrome app getting these requests.

R=xiyuan@chromium.org
BUG=611862
Committed: https://crrev.com/b3b024b69a6e3eabeb6cf6edd945f6f4d4f74067
Cr-Commit-Position: refs/heads/master@{#394282}

[rkc, 2016-05-17 05:30:18]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 05:30:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984723006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984723006/20001

[commit-bot: I haz the power, 2016-05-17 05:49:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 05:49:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rkc, 2016-05-17 08:12:11]

gyp fix

[rkc, 2016-05-17 08:14:26]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 08:14:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984723006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984723006/40001

[commit-bot: I haz the power, 2016-05-17 12:20:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 12:20:01]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2016-05-17 18:06:29]

lgtm

https://codereview.chromium.org/1984723006/diff/40001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluetooth_gatt_attribute_helpers.cc (right):

https://codereview.chromium.org/1984723006/diff/40001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_gatt_attribute_helpers.cc:17: const char
kDeviceField[] = "device";
nit: const -> constexpr

learned from my other review that constexpr is preferred.

https://codereview.chromium.org/1984723006/diff/40001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluetooth_gatt_attribute_helpers.h (right):

https://codereview.chromium.org/1984723006/diff/40001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_gatt_attribute_helpers.h:12: class MethodCall;
not used?

[rkc, 2016-05-17 18:42:59]

https://codereview.chromium.org/1984723006/diff/40001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluetooth_gatt_attribute_helpers.cc (right):

https://codereview.chromium.org/1984723006/diff/40001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_gatt_attribute_helpers.cc:17: const char
kDeviceField[] = "device";
On 2016/05/17 18:06:29, xiyuan wrote:
> nit: const -> constexpr
> 
> learned from my other review that constexpr is preferred.

Makes sense, since constexpr is compile-time.
Done.

https://codereview.chromium.org/1984723006/diff/40001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluetooth_gatt_attribute_helpers.h (right):

https://codereview.chromium.org/1984723006/diff/40001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_gatt_attribute_helpers.h:12: class MethodCall;
On 2016/05/17 18:06:29, xiyuan wrote:
> not used?

Done.

[scheib, 2016-05-17 20:03:57]

scheib@chromium.org changed reviewers:
+ scheib@chromium.org

[scheib, 2016-05-17 20:03:58]

LGTM

[rkc, 2016-05-17 21:30:17]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 21:30:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984723006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984723006/60001

[rkc, 2016-05-17 22:52:43]

The CQ bit was unchecked by rkc@chromium.org

[rkc, 2016-05-17 22:52:51]

The CQ bit was checked by rkc@chromium.org

[rkc, 2016-05-17 22:52:51]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1984723006/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-17 22:53:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984723006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984723006/60001

[commit-bot: I haz the power, 2016-05-18 00:28:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-18 00:30:01]

Description was changed from

==========
Add implementation for parsing device info in read/write attribute calls.

This CL adds the actual DBus implementation for parsing the device information
from the options dictionaries now passed up from BlueZ with the GATT
attribute value read/write request calls. It also plumbs the device
information up to the Chrome app getting these requests.

R=xiyuan@chromium.org
BUG=611862
==========

to

==========
Add implementation for parsing device info in read/write attribute calls.

This CL adds the actual DBus implementation for parsing the device information
from the options dictionaries now passed up from BlueZ with the GATT
attribute value read/write request calls. It also plumbs the device
information up to the Chrome app getting these requests.

R=xiyuan@chromium.org
BUG=611862

Committed: https://crrev.com/b3b024b69a6e3eabeb6cf6edd945f6f4d4f74067
Cr-Commit-Position: refs/heads/master@{#394282}
==========

[commit-bot: I haz the power, 2016-05-18 00:30:03]

Patchset 4 (id:??) landed as
https://crrev.com/b3b024b69a6e3eabeb6cf6edd945f6f4d4f74067
Cr-Commit-Position: refs/heads/master@{#394282}