device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc - Issue 1979163002: Add DBus plumbing and tests for sending devices with ATT read/writes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc

Issue 1979163002: Add DBus plumbing and tests for sending devices with ATT read/writes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@devices

Patch Set: gyp fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/dbus/bluetooth_gatt_characteristic_delegate_wrapper.cc ('k') | device/bluetooth/dbus/bluetooth_gatt_descriptor_delegate_wrapper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc

diff --git a/device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc b/device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc

index 3b3a44b1a28e517c0948bf5afa9aa9489ae4d756..939746abaddf5aad311c437ec1d3a3b92b5ae158 100644

--- a/device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc

+++ b/device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc

@@ -266,6 +266,7 @@ void BluetoothGattCharacteristicServiceProviderImpl::ReadValue(

DCHECK(OnOriginThread());

DCHECK(delegate_);

delegate_->GetValue(

+ dbus::ObjectPath(),

base::Bind(&BluetoothGattCharacteristicServiceProviderImpl::OnReadValue,

weak_ptr_factory_.GetWeakPtr(), method_call, response_sender),

base::Bind(&BluetoothGattCharacteristicServiceProviderImpl::OnFailure,

@@ -291,7 +292,7 @@ void BluetoothGattCharacteristicServiceProviderImpl::WriteValue(

DCHECK(delegate_);

delegate_->SetValue(

- value,

+ dbus::ObjectPath(), value,

base::Bind(&BluetoothGattCharacteristicServiceProviderImpl::OnWriteValue,

weak_ptr_factory_.GetWeakPtr(), method_call, response_sender),

base::Bind(&BluetoothGattCharacteristicServiceProviderImpl::OnFailure,