Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1978883002: In dialogs & dialog-like bubbles, make the escape button just close the prompt. (Closed)

Created:
4 years, 7 months ago by Evan Stade
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

In dialogs & dialog-like bubbles, make the escape button just close the prompt. Previously, the escape button would activate the negative button, which was relevant if that button did anything extra in addition to closing the prompt. This intentionally changes the permissions bubble (back to what it was before) as well as the bookmark bubble (now escape doesn't remove a new bookmark). Other bubbles may be affected and those changes are *probably* desired. UX contacts for this decision are hwi@ and ainslie@ BUG=609079, 163931 Review-Url: https://codereview.chromium.org/1953943003 Cr-Commit-Position: refs/heads/master@{#392708} (cherry picked from commit 0bf4ced694bba0aeb3ba518c7fe8435bc9018674) Committed: https://chromium.googlesource.com/chromium/src/+/567f799de8d6228d905c2d10d7db9fe0f4e81223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -45 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.h View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc View 1 chunk +1 line, -9 lines 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/window/dialog_delegate_unittest.cc View 5 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Evan Stade
4 years, 7 months ago (2016-05-13 16:46:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
567f799de8d6228d905c2d10d7db9fe0f4e81223.

Powered by Google App Engine
This is Rietveld 408576698