Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 1978883002: In dialogs & dialog-like bubbles, make the escape button just close the prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/ssl_client_certificate_selector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
index d9b93b66d767eddc5a6ab9c39e5764ab7ef68597..df0ed3c9a8af26fa6a74395722db4458a938baba 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
@@ -143,10 +143,6 @@ bool BookmarkBubbleView::AcceleratorPressed(
HandleButtonPressed(remove_button_);
return true;
}
- if (key_code == ui::VKEY_ESCAPE) {
- remove_bookmark_ = newly_bookmarked_;
- apply_edits_ = false;
- }
return LocationBarBubbleDelegateView::AcceleratorPressed(accelerator);
}
@@ -222,7 +218,6 @@ void BookmarkBubbleView::Init() {
AddAccelerator(ui::Accelerator(ui::VKEY_RETURN, ui::EF_NONE));
AddAccelerator(ui::Accelerator(ui::VKEY_E, ui::EF_ALT_DOWN));
AddAccelerator(ui::Accelerator(ui::VKEY_R, ui::EF_ALT_DOWN));
- AddAccelerator(ui::Accelerator(ui::VKEY_ESCAPE, ui::EF_NONE));
}
base::string16 BookmarkBubbleView::GetWindowTitle() const {
@@ -266,11 +261,11 @@ BookmarkBubbleView::BookmarkBubbleView(
parent_model_(BookmarkModelFactory::GetForProfile(profile_),
BookmarkModelFactory::GetForProfile(profile_)
->GetMostRecentlyAddedUserNodeForURL(url)),
- remove_button_(NULL),
- edit_button_(NULL),
- close_button_(NULL),
- title_tf_(NULL),
- parent_combobox_(NULL),
+ remove_button_(nullptr),
+ edit_button_(nullptr),
+ close_button_(nullptr),
+ title_tf_(nullptr),
+ parent_combobox_(nullptr),
remove_bookmark_(false),
apply_edits_(true) {}
« no previous file with comments | « no previous file | chrome/browser/ui/views/ssl_client_certificate_selector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698