Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc

Issue 1978883002: In dialogs & dialog-like bubbles, make the escape button just close the prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/files/file_path.h" 6 #include "base/files/file_path.h"
7 #include "base/synchronization/waitable_event.h" 7 #include "base/synchronization/waitable_event.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ssl/ssl_client_auth_requestor_mock.h" 10 #include "chrome/browser/ssl/ssl_client_auth_requestor_mock.h"
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 284
285 protected: 285 protected:
286 Browser* browser_1_; 286 Browser* browser_1_;
287 scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_1_; 287 scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_1_;
288 net::URLRequest* url_request_1_; 288 net::URLRequest* url_request_1_;
289 scoped_refptr<net::SSLCertRequestInfo> cert_request_info_1_; 289 scoped_refptr<net::SSLCertRequestInfo> cert_request_info_1_;
290 scoped_refptr<StrictMock<SSLClientAuthRequestorMock> > auth_requestor_1_; 290 scoped_refptr<StrictMock<SSLClientAuthRequestorMock> > auth_requestor_1_;
291 SSLClientCertificateSelector* selector_1_; 291 SSLClientCertificateSelector* selector_1_;
292 }; 292 };
293 293
294 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA) 294 IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorTest, SelectNone) {
295 // TODO(erg): linux_aura bringup: http://crbug.com/163931
296 #define MAYBE_SelectNone DISABLED_SelectNone
297 #else
298 #define MAYBE_SelectNone SelectNone
299 #endif
300
301
302 IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorTest, MAYBE_SelectNone) {
303 EXPECT_CALL(*auth_requestor_.get(), CancelCertificateSelection()); 295 EXPECT_CALL(*auth_requestor_.get(), CancelCertificateSelection());
304 296
305 // Let the mock get checked on destruction. 297 // Let the mock get checked on destruction.
306 } 298 }
307 299
308 IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorTest, Escape) { 300 IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorTest, Escape) {
309 EXPECT_CALL(*auth_requestor_.get(), CertificateSelected(NULL)); 301 EXPECT_CALL(*auth_requestor_.get(), CertificateSelected(NULL));
310 302
311 EXPECT_TRUE(ui_test_utils::SendKeyPressSync( 303 EXPECT_TRUE(ui_test_utils::SendKeyPressSync(
312 browser(), ui::VKEY_ESCAPE, false, false, false, false)); 304 browser(), ui::VKEY_ESCAPE, false, false, false, false));
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 EXPECT_TRUE(ui_test_utils::SendKeyPressSync( 385 EXPECT_TRUE(ui_test_utils::SendKeyPressSync(
394 browser_1_, ui::VKEY_RETURN, false, false, false, false)); 386 browser_1_, ui::VKEY_RETURN, false, false, false, false));
395 387
396 Mock::VerifyAndClear(auth_requestor_.get()); 388 Mock::VerifyAndClear(auth_requestor_.get());
397 Mock::VerifyAndClear(auth_requestor_1_.get()); 389 Mock::VerifyAndClear(auth_requestor_1_.get());
398 390
399 // Now let the default selection for auth_requestor_ mock get checked on 391 // Now let the default selection for auth_requestor_ mock get checked on
400 // destruction. 392 // destruction.
401 EXPECT_CALL(*auth_requestor_.get(), CancelCertificateSelection()); 393 EXPECT_CALL(*auth_requestor_.get(), CancelCertificateSelection());
402 } 394 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/ssl_client_certificate_selector.cc ('k') | ui/views/window/dialog_client_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698