chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc - Issue 1978883002: In dialogs & dialog-like bubbles, make the escape button just close the prompt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc

Issue 1978883002: In dialogs & dialog-like bubbles, make the escape button just close the prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc

diff --git a/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc b/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc

index 49b2c46fd08fb69e7ab0bf3aa3c249b446d3b12b..825971d770184d196e0739d72ba9f39ad1f6ef18 100644

--- a/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc

+++ b/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc

@@ -291,15 +291,7 @@ class SSLClientCertificateSelectorMultiProfileTest

SSLClientCertificateSelector* selector_1_;

};

-#if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA)

-// TODO(erg): linux_aura bringup: http://crbug.com/163931

-#define MAYBE_SelectNone DISABLED_SelectNone

-#else

-#define MAYBE_SelectNone SelectNone

-#endif

-IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorTest, MAYBE_SelectNone) {

+IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorTest, SelectNone) {

EXPECT_CALL(*auth_requestor_.get(), CancelCertificateSelection());

// Let the mock get checked on destruction.

« no previous file with comments | « chrome/browser/ui/views/ssl_client_certificate_selector.cc ('k') | ui/views/window/dialog_client_view.cc » ('j') | no next file with comments »