Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: Source/core/html/HTMLFrameElementBase.h

Issue 197873022: Drop Element::isHTMLFrameElementBase() virtual function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Take tkent's feedback into consideration Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLBodyElement.cpp ('k') | Source/core/page/EventHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFrameElementBase.h
diff --git a/Source/core/html/HTMLFrameElementBase.h b/Source/core/html/HTMLFrameElementBase.h
index 82c501362baa4697a01ebdf9a64c9c42fb903451..c774006c4c6f737be3dcd2516c1e11dd2a37968b 100644
--- a/Source/core/html/HTMLFrameElementBase.h
+++ b/Source/core/html/HTMLFrameElementBase.h
@@ -61,8 +61,6 @@ private:
virtual bool isURLAttribute(const Attribute&) const OVERRIDE FINAL;
virtual bool isHTMLContentAttribute(const Attribute&) const OVERRIDE FINAL;
- virtual bool isFrameElementBase() const OVERRIDE FINAL { return true; }
-
virtual bool areAuthorShadowsAllowed() const OVERRIDE FINAL { return false; }
void setNameAndOpenURL();
@@ -79,7 +77,12 @@ private:
inline bool isHTMLFrameElementBase(const Node& node)
{
- return node.isElementNode() && toElement(node).isFrameElementBase();
+ return isHTMLFrameElement(node) || isHTMLIFrameElement(node);
+}
+
+inline bool isHTMLFrameElementBase(const Node* node)
+{
+ return node && isHTMLFrameElementBase(*node);
}
DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFrameElementBase);
« no previous file with comments | « Source/core/html/HTMLBodyElement.cpp ('k') | Source/core/page/EventHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698