Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1977503003: [Offline pages] Removes the functionality to get bookmark ID from offline URL (Closed)

Created:
4 years, 7 months ago by fgorski
Modified:
4 years, 7 months ago
Reviewers:
Pete Williamson
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bookmark-star
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Removes the functionality to get bookmark ID from offline URL BUG=603940 Committed: https://crrev.com/517c5ffb2369cfc7253fd43982ab3b9f1f51049f Cr-Commit-Position: refs/heads/master@{#393314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M chrome/browser/android/offline_pages/offline_page_utils.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_utils.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_utils_unittest.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Depends on Patchset:

Issue 1973033002 Patch 1

Messages

Total messages: 8 (3 generated)
fgorski
Pete, PTAL
4 years, 7 months ago (2016-05-12 17:30:42 UTC) #2
Pete Williamson
lgtm
4 years, 7 months ago (2016-05-12 17:31:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977503003/1
4 years, 7 months ago (2016-05-12 17:58:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 18:38:33 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 18:40:18 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/517c5ffb2369cfc7253fd43982ab3b9f1f51049f
Cr-Commit-Position: refs/heads/master@{#393314}

Powered by Google App Engine
This is Rietveld 408576698