Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1973033002: [Offline pages] Lighting up the bookmark star for saved recent pages (Closed)

Created:
4 years, 7 months ago by fgorski
Modified:
4 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Lighting up the bookmark star for saved recent pages This patch replaces a lookup for bookmark ID, based on offline URL with a lookup of original online URL based on offline URL, and then looks up a bookmark ID based on that, the way it is done when starting with original URL. BUG=603940 Committed: https://crrev.com/28b4b671d156128aa26839393983d960149abf57 Cr-Commit-Position: refs/heads/master@{#393296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M chrome/browser/android/tab_android.cc View 2 chunks +5 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
fgorski
Ted, PTAL
4 years, 7 months ago (2016-05-12 17:23:59 UTC) #3
Ted C
On 2016/05/12 17:23:59, fgorski wrote: > Ted, PTAL lgtm
4 years, 7 months ago (2016-05-12 17:27:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973033002/1
4 years, 7 months ago (2016-05-12 17:33:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 17:54:25 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 17:57:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28b4b671d156128aa26839393983d960149abf57
Cr-Commit-Position: refs/heads/master@{#393296}

Powered by Google App Engine
This is Rietveld 408576698