Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2747)

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

Issue 1977503003: [Offline pages] Removes the functionality to get bookmark ID from offline URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmark-star
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
index 7e8f0a3aaacb3caaa031de9a9ed79a49498bd00f..4069d1ce2e561b1d3914670c574ba75c6f10f559 100644
--- a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
+++ b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
@@ -37,8 +37,6 @@ const GURL kTestPage3Url("http://test.org/page3");
const int64_t kTestFileSize = 876543LL;
const char* kTestPage1ClientId = "1234";
const char* kTestPage2ClientId = "5678";
-const int64_t kTestPage1BookmarkId = 1234;
-const int64_t kTestPage2BookmarkId = 5678;
} // namespace
@@ -207,15 +205,6 @@ TEST_F(OfflinePageUtilsTest, GetOnlineURLForOfflineURL) {
profile(), offline_url_missing()));
}
-TEST_F(OfflinePageUtilsTest, GetBookmarkIdForOfflineURL) {
- EXPECT_EQ(kTestPage1BookmarkId, OfflinePageUtils::GetBookmarkIdForOfflineURL(
- profile(), offline_url_page_1()));
- EXPECT_EQ(kTestPage2BookmarkId, OfflinePageUtils::GetBookmarkIdForOfflineURL(
- profile(), offline_url_page_2()));
- EXPECT_EQ(-1, OfflinePageUtils::GetBookmarkIdForOfflineURL(
- profile(), offline_url_missing()));
-}
-
TEST_F(OfflinePageUtilsTest, IsOfflinePage) {
EXPECT_TRUE(OfflinePageUtils::IsOfflinePage(profile(), offline_url_page_1()));
EXPECT_TRUE(OfflinePageUtils::IsOfflinePage(profile(), offline_url_page_2()));
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698