Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

Issue 1977503003: [Offline pages] Removes the functionality to get bookmark ID from offline URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmark-star
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/offline_page_utils.h" 5 #include "chrome/browser/android/offline_pages/offline_page_utils.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 19 matching lines...) Expand all
30 30
31 namespace offline_pages { 31 namespace offline_pages {
32 namespace { 32 namespace {
33 33
34 const GURL kTestPage1Url("http://test.org/page1"); 34 const GURL kTestPage1Url("http://test.org/page1");
35 const GURL kTestPage2Url("http://test.org/page2"); 35 const GURL kTestPage2Url("http://test.org/page2");
36 const GURL kTestPage3Url("http://test.org/page3"); 36 const GURL kTestPage3Url("http://test.org/page3");
37 const int64_t kTestFileSize = 876543LL; 37 const int64_t kTestFileSize = 876543LL;
38 const char* kTestPage1ClientId = "1234"; 38 const char* kTestPage1ClientId = "1234";
39 const char* kTestPage2ClientId = "5678"; 39 const char* kTestPage2ClientId = "5678";
40 const int64_t kTestPage1BookmarkId = 1234;
41 const int64_t kTestPage2BookmarkId = 5678;
42 40
43 } // namespace 41 } // namespace
44 42
45 class OfflinePageUtilsTest 43 class OfflinePageUtilsTest
46 : public testing::Test, 44 : public testing::Test,
47 public OfflinePageTestArchiver::Observer, 45 public OfflinePageTestArchiver::Observer,
48 public base::SupportsWeakPtr<OfflinePageUtilsTest> { 46 public base::SupportsWeakPtr<OfflinePageUtilsTest> {
49 public: 47 public:
50 OfflinePageUtilsTest(); 48 OfflinePageUtilsTest();
51 ~OfflinePageUtilsTest() override; 49 ~OfflinePageUtilsTest() override;
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 198
201 TEST_F(OfflinePageUtilsTest, GetOnlineURLForOfflineURL) { 199 TEST_F(OfflinePageUtilsTest, GetOnlineURLForOfflineURL) {
202 EXPECT_EQ(kTestPage1Url, OfflinePageUtils::GetOnlineURLForOfflineURL( 200 EXPECT_EQ(kTestPage1Url, OfflinePageUtils::GetOnlineURLForOfflineURL(
203 profile(), offline_url_page_1())); 201 profile(), offline_url_page_1()));
204 EXPECT_EQ(kTestPage2Url, OfflinePageUtils::GetOnlineURLForOfflineURL( 202 EXPECT_EQ(kTestPage2Url, OfflinePageUtils::GetOnlineURLForOfflineURL(
205 profile(), offline_url_page_2())); 203 profile(), offline_url_page_2()));
206 EXPECT_EQ(GURL::EmptyGURL(), OfflinePageUtils::GetOnlineURLForOfflineURL( 204 EXPECT_EQ(GURL::EmptyGURL(), OfflinePageUtils::GetOnlineURLForOfflineURL(
207 profile(), offline_url_missing())); 205 profile(), offline_url_missing()));
208 } 206 }
209 207
210 TEST_F(OfflinePageUtilsTest, GetBookmarkIdForOfflineURL) {
211 EXPECT_EQ(kTestPage1BookmarkId, OfflinePageUtils::GetBookmarkIdForOfflineURL(
212 profile(), offline_url_page_1()));
213 EXPECT_EQ(kTestPage2BookmarkId, OfflinePageUtils::GetBookmarkIdForOfflineURL(
214 profile(), offline_url_page_2()));
215 EXPECT_EQ(-1, OfflinePageUtils::GetBookmarkIdForOfflineURL(
216 profile(), offline_url_missing()));
217 }
218
219 TEST_F(OfflinePageUtilsTest, IsOfflinePage) { 208 TEST_F(OfflinePageUtilsTest, IsOfflinePage) {
220 EXPECT_TRUE(OfflinePageUtils::IsOfflinePage(profile(), offline_url_page_1())); 209 EXPECT_TRUE(OfflinePageUtils::IsOfflinePage(profile(), offline_url_page_1()));
221 EXPECT_TRUE(OfflinePageUtils::IsOfflinePage(profile(), offline_url_page_2())); 210 EXPECT_TRUE(OfflinePageUtils::IsOfflinePage(profile(), offline_url_page_2()));
222 EXPECT_FALSE( 211 EXPECT_FALSE(
223 OfflinePageUtils::IsOfflinePage(profile(), offline_url_missing())); 212 OfflinePageUtils::IsOfflinePage(profile(), offline_url_missing()));
224 EXPECT_FALSE(OfflinePageUtils::IsOfflinePage(profile(), kTestPage1Url)); 213 EXPECT_FALSE(OfflinePageUtils::IsOfflinePage(profile(), kTestPage1Url));
225 EXPECT_FALSE(OfflinePageUtils::IsOfflinePage(profile(), kTestPage2Url)); 214 EXPECT_FALSE(OfflinePageUtils::IsOfflinePage(profile(), kTestPage2Url));
226 } 215 }
227 216
228 TEST_F(OfflinePageUtilsTest, HasOfflinePageForOnlineURL) { 217 TEST_F(OfflinePageUtilsTest, HasOfflinePageForOnlineURL) {
229 EXPECT_TRUE( 218 EXPECT_TRUE(
230 OfflinePageUtils::HasOfflinePageForOnlineURL(profile(), kTestPage1Url)); 219 OfflinePageUtils::HasOfflinePageForOnlineURL(profile(), kTestPage1Url));
231 EXPECT_TRUE( 220 EXPECT_TRUE(
232 OfflinePageUtils::HasOfflinePageForOnlineURL(profile(), kTestPage2Url)); 221 OfflinePageUtils::HasOfflinePageForOnlineURL(profile(), kTestPage2Url));
233 EXPECT_FALSE( 222 EXPECT_FALSE(
234 OfflinePageUtils::HasOfflinePageForOnlineURL(profile(), kTestPage3Url)); 223 OfflinePageUtils::HasOfflinePageForOnlineURL(profile(), kTestPage3Url));
235 } 224 }
236 225
237 } // namespace offline_pages 226 } // namespace offline_pages
OLDNEW
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698