Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1977463002: Prerender: Remove MatchComplete status. (Closed)

Created:
4 years, 7 months ago by pasko
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, davidben+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prerender: Remove MatchComplete status. BUG=609105 Committed: https://crrev.com/6ee988e42a302a5d46065681030d005981485457 Cr-Commit-Position: refs/heads/master@{#393341}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -113 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 1 chunk +5 lines, -8 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 4 chunks +0 lines, -41 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_histograms.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_histograms.cc View 2 chunks +3 lines, -18 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 2 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 3 chunks +10 lines, -22 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
pasko
4 years, 7 months ago (2016-05-12 17:13:49 UTC) #2
mmenke
LGTM
4 years, 7 months ago (2016-05-12 17:44:00 UTC) #3
pasko
asvitkine: PTaL at histograms.xml
4 years, 7 months ago (2016-05-12 19:06:32 UTC) #5
Alexei Svitkine (slow)
lgtm
4 years, 7 months ago (2016-05-12 19:09:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977463002/40001
4 years, 7 months ago (2016-05-12 19:10:49 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-12 20:23:34 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 20:25:21 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6ee988e42a302a5d46065681030d005981485457
Cr-Commit-Position: refs/heads/master@{#393341}

Powered by Google App Engine
This is Rietveld 408576698