Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5298)

Unified Diff: chrome/browser/prerender/prerender_contents.h

Issue 1977463002: Prerender: Remove MatchComplete status. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/prerender/prerender_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_contents.h
diff --git a/chrome/browser/prerender/prerender_contents.h b/chrome/browser/prerender/prerender_contents.h
index 3661e507f73924760661eaf400697f7edca309d5..d8f3f7d16b1b801803d02f91337285099a136045 100644
--- a/chrome/browser/prerender/prerender_contents.h
+++ b/chrome/browser/prerender/prerender_contents.h
@@ -91,31 +91,6 @@ class PrerenderContents : public content::NotificationObserver,
virtual ~Observer() = 0;
};
- // Indicates how this PrerenderContents relates to MatchComplete. This is to
- // figure out which histograms to use to record the FinalStatus, Match (record
- // all prerenders and control group prerenders) or MatchComplete (record
- // running prerenders only in the way they would have been recorded in the
- // control group).
- // TODO(pasko): Remove the dead code associated with non-default
- // MatchCompleteStatus.
- enum MatchCompleteStatus {
- // A regular prerender which will be recorded both in Match and
- // MatchComplete.
- MATCH_COMPLETE_DEFAULT,
- // A prerender that used to be a regular prerender, but has since been
- // replaced by a MatchComplete dummy. Therefore, we will record this only
- // for Match, but not for MatchComplete.
- MATCH_COMPLETE_REPLACED,
- // A prerender that is a MatchComplete dummy replacing a regular prerender.
- // In the control group, our prerender never would have been canceled, so
- // we record in MatchComplete but not Match.
- MATCH_COMPLETE_REPLACEMENT,
- // A prerender that is a MatchComplete dummy, early in the process of being
- // created. This prerender should not fail. Record for MatchComplete, but
- // not Match.
- MATCH_COMPLETE_REPLACEMENT_PENDING,
- };
-
~PrerenderContents() override;
// All observers of a PrerenderContents are removed after the OnPrerenderStop
@@ -124,11 +99,6 @@ class PrerenderContents : public content::NotificationObserver,
void AddObserver(Observer* observer);
void RemoveObserver(Observer* observer);
- // For MatchComplete correctness, create a dummy replacement prerender
- // contents to stand in for this prerender contents that (which we are about
- // to destroy).
- PrerenderContents* CreateMatchCompleteReplacement();
-
bool Init();
static Factory* CreateFactory();
@@ -163,12 +133,6 @@ class PrerenderContents : public content::NotificationObserver,
bool has_stopped_loading() const { return has_stopped_loading_; }
bool has_finished_loading() const { return has_finished_loading_; }
bool prerendering_has_started() const { return prerendering_has_started_; }
- MatchCompleteStatus match_complete_status() const {
- return match_complete_status_;
- }
- void set_match_complete_status(MatchCompleteStatus status) {
- match_complete_status_ = status;
- }
// Sets the parameter to the value of the associated RenderViewHost's child id
// and returns a boolean indicating the validity of that id.
@@ -362,11 +326,6 @@ class PrerenderContents : public content::NotificationObserver,
FinalStatus final_status_;
- // The MatchComplete status of the prerender, indicating how it relates
- // to being a MatchComplete dummy (see definition of MatchCompleteStatus
- // above).
- MatchCompleteStatus match_complete_status_;
-
// Tracks whether or not prerendering has been cancelled by calling Destroy.
// Used solely to prevent double deletion.
bool prerendering_has_been_cancelled_;
« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/prerender/prerender_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698