Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/browser/prerender/prerender_manager.h

Issue 1977463002: Prerender: Remove MatchComplete status. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_histograms.cc ('k') | chrome/browser/prerender/prerender_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_manager.h
diff --git a/chrome/browser/prerender/prerender_manager.h b/chrome/browser/prerender/prerender_manager.h
index 41f500721ae0c263561459d94e246d40d9d9513e..28b26a83a6e3fe499436eff2f84bc1db6dcf6924 100644
--- a/chrome/browser/prerender/prerender_manager.h
+++ b/chrome/browser/prerender/prerender_manager.h
@@ -273,12 +273,7 @@ class PrerenderManager : public base::SupportsWeakPtr<PrerenderManager>,
void ClearData(int clear_flags);
// Record a final status of a prerendered page in a histogram.
- // This variation allows specifying whether prerendering had been started
- // (necessary to flag MatchComplete dummies).
- void RecordFinalStatusWithMatchCompleteStatus(
- Origin origin,
- PrerenderContents::MatchCompleteStatus mc_status,
- FinalStatus final_status) const;
+ void RecordFinalStatus(Origin origin, FinalStatus final_status) const;
// content::NotificationObserver
void Observe(int type,
@@ -499,16 +494,8 @@ class PrerenderManager : public base::SupportsWeakPtr<PrerenderManager>,
// Used both on destruction, and when clearing the browsing history.
void DestroyAllContents(FinalStatus final_status);
- // Helper function to destroy a PrerenderContents with the specified
- // final_status, while at the same time recording that for the MatchComplete
- // case, that this prerender would have been used.
- void DestroyAndMarkMatchCompleteAsUsed(PrerenderContents* prerender_contents,
- FinalStatus final_status);
-
// Records the final status a prerender in the case that a PrerenderContents
// was never created, and also adds a PrerenderHistory entry.
- // This is a helper function which will ultimately call
- // RecordFinalStatusWthMatchCompleteStatus, using MATCH_COMPLETE_DEFAULT.
void RecordFinalStatusWithoutCreatingPrerenderContents(
const GURL& url, Origin origin, FinalStatus final_status) const;
« no previous file with comments | « chrome/browser/prerender/prerender_histograms.cc ('k') | chrome/browser/prerender/prerender_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698