Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1757)

Unified Diff: chrome/browser/prerender/prerender_histograms.cc

Issue 1977463002: Prerender: Remove MatchComplete status. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_histograms.h ('k') | chrome/browser/prerender/prerender_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_histograms.cc
diff --git a/chrome/browser/prerender/prerender_histograms.cc b/chrome/browser/prerender/prerender_histograms.cc
index 30d9f03731e86b394ce9e4b221873884b51d397e..9df289dd32d738337524938e56c2e93133175a6e 100644
--- a/chrome/browser/prerender/prerender_histograms.cc
+++ b/chrome/browser/prerender/prerender_histograms.cc
@@ -206,9 +206,6 @@ base::TimeTicks PrerenderHistograms::GetCurrentTimeTicks() const {
// and Control group cases, while nothing ever gets swapped in, we do keep
// track of what would be prerendered and would be swapped in -- and those
// cases are what is classified as Match for these groups.
-// ...MatchedComplete -- A prerendered page that was swapped in + a few
-// that were not swapped in so that the set of pages lines up more closely with
-// the control group.
// ...FirstAfterMiss -- First page to finish loading after a prerender, which
// is different from the page that was prerendered.
// ...FirstAfterMissNonOverlapping -- Same as FirstAfterMiss, but only
@@ -349,23 +346,11 @@ void PrerenderHistograms::RecordTimeBetweenPrerenderRequests(
void PrerenderHistograms::RecordFinalStatus(
Origin origin,
- PrerenderContents::MatchCompleteStatus mc_status,
FinalStatus final_status) const {
DCHECK(final_status != FINAL_STATUS_MAX);
-
- if (mc_status == PrerenderContents::MATCH_COMPLETE_DEFAULT ||
- mc_status == PrerenderContents::MATCH_COMPLETE_REPLACED) {
- PREFIXED_HISTOGRAM_ORIGIN_EXPERIMENT(
- "FinalStatus", origin,
- UMA_HISTOGRAM_ENUMERATION(name, final_status, FINAL_STATUS_MAX));
- }
- if (mc_status == PrerenderContents::MATCH_COMPLETE_DEFAULT ||
- mc_status == PrerenderContents::MATCH_COMPLETE_REPLACEMENT ||
- mc_status == PrerenderContents::MATCH_COMPLETE_REPLACEMENT_PENDING) {
- PREFIXED_HISTOGRAM_ORIGIN_EXPERIMENT(
- "FinalStatusMatchComplete", origin,
- UMA_HISTOGRAM_ENUMERATION(name, final_status, FINAL_STATUS_MAX));
- }
+ PREFIXED_HISTOGRAM_ORIGIN_EXPERIMENT(
+ "FinalStatus", origin,
+ UMA_HISTOGRAM_ENUMERATION(name, final_status, FINAL_STATUS_MAX));
}
void PrerenderHistograms::RecordNetworkBytes(Origin origin,
« no previous file with comments | « chrome/browser/prerender/prerender_histograms.h ('k') | chrome/browser/prerender/prerender_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698