Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1977033002: Make ServiceRegistry (which implements) ApplicationConnection just wrap a ServiceProviderImpl. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make ServiceRegistry (which implements) ApplicationConnection just wrap a ServiceProviderImpl. At this point, I could make ApplicationConnection not an interface, and just rename ServiceRegistry to ApplicationConnection (basically). I won't bother, because I plan on deleting ApplicationConnection/ServiceRegistry ASAP. I also added a ServiceProviderImpl getter to ApplicationConnection. My plan of action is: * Make everyone currently using ApplicationConnection just use stuff via the getter. (In particular, this means converting all the current uses of ApplicationConnection::AddService<I>()/InterfaceFactory<I>.) * At that point, replacing ApplicationConnection with just ServiceProviderImpl will be easy. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/721c34a0c8b9cde24940a2cbbb6173897b79ed6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -32 lines) Patch
M mojo/public/cpp/application/application_connection.h View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/public/cpp/application/lib/service_provider_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/lib/service_registry.h View 4 chunks +4 lines, -12 lines 0 comments Download
M mojo/public/cpp/application/lib/service_registry.cc View 1 chunk +11 lines, -16 lines 0 comments Download
M mojo/public/cpp/application/service_provider_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/application/tests/service_provider_impl_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-13 16:50:01 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-13 18:06:59 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-13 18:12:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
721c34a0c8b9cde24940a2cbbb6173897b79ed6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698