Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: mojo/public/cpp/application/tests/service_provider_impl_unittest.cc

Issue 1977033002: Make ServiceRegistry (which implements) ApplicationConnection just wrap a ServiceProviderImpl. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/application/service_provider_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/application/tests/service_provider_impl_unittest.cc
diff --git a/mojo/public/cpp/application/tests/service_provider_impl_unittest.cc b/mojo/public/cpp/application/tests/service_provider_impl_unittest.cc
index 2483fc3ce152b1540d09e070640bd62654c1fdd5..f6767672d28ac97239ff6430fbc2833dccf715e0 100644
--- a/mojo/public/cpp/application/tests/service_provider_impl_unittest.cc
+++ b/mojo/public/cpp/application/tests/service_provider_impl_unittest.cc
@@ -338,6 +338,16 @@ TEST_F(ServiceProviderImplTest, FallbackServiceProvider) {
EXPECT_FALSE(was_run);
}
+TEST_F(ServiceProviderImplTest, ConstructRequestNotPending) {
+ ServiceProviderImpl impl(ConnectionContext(ConnectionContext::Type::INCOMING,
+ "https://example.com/remote.mojo",
+ "https://example.com/me.mojo"),
+ InterfaceRequest<ServiceProvider>());
+ EXPECT_EQ(ConnectionContext::Type::UNKNOWN, impl.connection_context().type);
+ EXPECT_EQ(std::string(), impl.connection_context().remote_url);
+ EXPECT_EQ(std::string(), impl.connection_context().connection_url);
+}
+
// TODO(vtl): Explicitly test |AddServiceForName()|?
} // namespace
« no previous file with comments | « mojo/public/cpp/application/service_provider_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698