mojo/public/cpp/application/service_provider_impl.h - Issue 1977033002: Make ServiceRegistry (which implements) ApplicationConnection just wrap a ServiceProviderImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/application/service_provider_impl.h

Issue 1977033002: Make ServiceRegistry (which implements) ApplicationConnection just wrap a ServiceProviderImpl. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/application/lib/service_registry.cc ('k') | mojo/public/cpp/application/tests/service_provider_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/application/service_provider_impl.h

diff --git a/mojo/public/cpp/application/service_provider_impl.h b/mojo/public/cpp/application/service_provider_impl.h

index 54adac77bf41cfbb9bb78102f517a1eb0cbefaa9..77a76445f408808823ee6abd7c7e9f6f17930c1f 100644

--- a/mojo/public/cpp/application/service_provider_impl.h

+++ b/mojo/public/cpp/application/service_provider_impl.h

@@ -35,7 +35,8 @@ class ServiceProviderImpl : public ServiceProvider {

ServiceProviderImpl();

// Constructs this service provider implementation, binding it to the given

- // interface request.

+ // interface request. Note: If |service_provider_request| is not valid

+ // ("pending"), then the object will be put into an unbound state.

explicit ServiceProviderImpl(

const ConnectionContext& connection_context,

InterfaceRequest<ServiceProvider> service_provider_request);