Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1977043002: ApplicationConnection devolution, part 1. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work791_service_registry_spimpl
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

ApplicationConnection devolution, part 1. Remove everything from ApplicationConnection other than GetServiceProviderImpl() (which is a pure virtual method) and AddService<I>() (which is a templated method). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/087fc161f2e8c84878f916ed3726937860f60c67

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -125 lines) Patch
M examples/bank_app/bank.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/application/application_connection.h View 2 chunks +4 lines, -23 lines 0 comments Download
M mojo/public/cpp/application/lib/service_registry.h View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/public/cpp/application/lib/service_registry.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M mojo/public/cpp/application/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/cpp/application/tests/service_registry_unittest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M services/dart/content_handler_main.cc View 1 chunk +3 lines, -1 line 0 comments Download
M services/python/content_handler/content_handler_main.cc View 1 chunk +3 lines, -1 line 0 comments Download
M services/ui/launcher/launcher_app.cc View 1 chunk +3 lines, -1 line 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/1977033002/.
4 years, 7 months ago (2016-05-13 17:13:11 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-13 18:09:26 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-13 18:16:01 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
087fc161f2e8c84878f916ed3726937860f60c67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698