Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1976123003: Remove { delete this; } anti-pattern from IXFA_WidgetIterator (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove { delete this; } anti-pattern from IXFA_WidgetIterator Committed: https://pdfium.googlesource.com/pdfium/+/cc4d6d85b58a7a1d9d7b798c63d3343f3dac06a9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Restore page Release(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -43 lines) Patch
M fpdfsdk/fpdfformfill.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fsdk_annothandler.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
M fpdfsdk/fsdk_mgr.cpp View 1 2 chunks +5 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpageview.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_rendercontext.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M xfa/fxfa/include/fxfa.h View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/fxfa/include/xfa_ffdocview.h View 1 chunk +11 lines, -11 lines 0 comments Download
M xfa/fxfa/include/xfa_ffpageview.h View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-05-14 00:37:20 UTC) #2
Lei Zhang
https://codereview.chromium.org/1976123003/diff/1/fpdfsdk/fsdk_mgr.cpp File fpdfsdk/fsdk_mgr.cpp (left): https://codereview.chromium.org/1976123003/diff/1/fpdfsdk/fsdk_mgr.cpp#oldcode913 fpdfsdk/fsdk_mgr.cpp:913: m_page->Release(); Isn't this still needed to balance out line ...
4 years, 7 months ago (2016-05-14 00:43:53 UTC) #3
Tom Sepez
https://codereview.chromium.org/1976123003/diff/1/fpdfsdk/fsdk_mgr.cpp File fpdfsdk/fsdk_mgr.cpp (left): https://codereview.chromium.org/1976123003/diff/1/fpdfsdk/fsdk_mgr.cpp#oldcode913 fpdfsdk/fsdk_mgr.cpp:913: m_page->Release(); On 2016/05/14 00:43:53, Lei Zhang wrote: > Isn't ...
4 years, 7 months ago (2016-05-16 16:15:59 UTC) #4
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-16 18:52:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976123003/20001
4 years, 7 months ago (2016-05-16 18:56:21 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 20:21:09 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/cc4d6d85b58a7a1d9d7b798c63d3343f3dac...

Powered by Google App Engine
This is Rietveld 408576698