Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: xfa/fxfa/include/fxfa.h

Issue 1976123003: Remove { delete this; } anti-pattern from IXFA_WidgetIterator (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Restore page Release(). Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fxfa/app/xfa_rendercontext.cpp ('k') | xfa/fxfa/include/xfa_ffdocview.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef XFA_FXFA_INCLUDE_FXFA_H_ 7 #ifndef XFA_FXFA_INCLUDE_FXFA_H_
8 #define XFA_FXFA_INCLUDE_FXFA_H_ 8 #define XFA_FXFA_INCLUDE_FXFA_H_
9 9
10 #include <vector> 10 #include <vector>
(...skipping 518 matching lines...) Expand 10 before | Expand all | Expand 10 after
529 529
530 class CXFA_RenderOptions { 530 class CXFA_RenderOptions {
531 public: 531 public:
532 CXFA_RenderOptions() : m_bPrint(FALSE), m_bHighlight(TRUE) {} 532 CXFA_RenderOptions() : m_bPrint(FALSE), m_bHighlight(TRUE) {}
533 FX_BOOL m_bPrint; 533 FX_BOOL m_bPrint;
534 FX_BOOL m_bHighlight; 534 FX_BOOL m_bHighlight;
535 }; 535 };
536 536
537 class IXFA_WidgetIterator { 537 class IXFA_WidgetIterator {
538 public: 538 public:
539 virtual void Release() = 0; 539 virtual ~IXFA_WidgetIterator() {}
540
540 virtual void Reset() = 0; 541 virtual void Reset() = 0;
541 virtual CXFA_FFWidget* MoveToFirst() = 0; 542 virtual CXFA_FFWidget* MoveToFirst() = 0;
542 virtual CXFA_FFWidget* MoveToLast() = 0; 543 virtual CXFA_FFWidget* MoveToLast() = 0;
543 virtual CXFA_FFWidget* MoveToNext() = 0; 544 virtual CXFA_FFWidget* MoveToNext() = 0;
544 virtual CXFA_FFWidget* MoveToPrevious() = 0; 545 virtual CXFA_FFWidget* MoveToPrevious() = 0;
545 virtual CXFA_FFWidget* GetCurrentWidget() = 0; 546 virtual CXFA_FFWidget* GetCurrentWidget() = 0;
546 virtual FX_BOOL SetCurrentWidget(CXFA_FFWidget* hWidget) = 0; 547 virtual FX_BOOL SetCurrentWidget(CXFA_FFWidget* hWidget) = 0;
547
548 protected:
549 virtual ~IXFA_WidgetIterator() {}
550 }; 548 };
551 549
552 #endif // XFA_FXFA_INCLUDE_FXFA_H_ 550 #endif // XFA_FXFA_INCLUDE_FXFA_H_
OLDNEW
« no previous file with comments | « xfa/fxfa/app/xfa_rendercontext.cpp ('k') | xfa/fxfa/include/xfa_ffdocview.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698