Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: xfa/fxfa/app/xfa_rendercontext.cpp

Issue 1976123003: Remove { delete this; } anti-pattern from IXFA_WidgetIterator (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Restore page Release(). Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fxfa/app/xfa_ffpageview.cpp ('k') | xfa/fxfa/include/fxfa.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fxfa/include/xfa_rendercontext.h" 7 #include "xfa/fxfa/include/xfa_rendercontext.h"
8 8
9 #include "xfa/fxfa/include/xfa_ffpageview.h" 9 #include "xfa/fxfa/include/xfa_ffpageview.h"
10 #include "xfa/fxfa/include/xfa_ffwidget.h" 10 #include "xfa/fxfa/include/xfa_ffwidget.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 m_pWidget = m_pWidgetIterator->MoveToNext(); 61 m_pWidget = m_pWidgetIterator->MoveToNext();
62 iCount++; 62 iCount++;
63 if (iCount > XFA_RENDERCONTEXT_MaxCount && pPause && 63 if (iCount > XFA_RENDERCONTEXT_MaxCount && pPause &&
64 pPause->NeedToPauseNow()) { 64 pPause->NeedToPauseNow()) {
65 return XFA_RENDERSTATUS_ToBeContinued; 65 return XFA_RENDERSTATUS_ToBeContinued;
66 } 66 }
67 } 67 }
68 return XFA_RENDERSTATUS_Done; 68 return XFA_RENDERSTATUS_Done;
69 } 69 }
70 void CXFA_RenderContext::StopRender() { 70 void CXFA_RenderContext::StopRender() {
71 if (m_pWidgetIterator) { 71 delete m_pWidgetIterator;
72 m_pWidgetIterator->Release(); 72 m_pWidgetIterator = nullptr;
73 m_pWidgetIterator = NULL;
74 }
75 } 73 }
OLDNEW
« no previous file with comments | « xfa/fxfa/app/xfa_ffpageview.cpp ('k') | xfa/fxfa/include/fxfa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698