xfa/fxfa/app/xfa_rendercontext.cpp - Issue 1976123003: Remove { delete this; } anti-pattern from IXFA_WidgetIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/app/xfa_rendercontext.cpp

Issue 1976123003: Remove { delete this; } anti-pattern from IXFA_WidgetIterator (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Restore page Release(). Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/app/xfa_rendercontext.cpp

diff --git a/xfa/fxfa/app/xfa_rendercontext.cpp b/xfa/fxfa/app/xfa_rendercontext.cpp

index cc2ea4b9ac28ec872239aea4ba4edae500f2b782..e7bacec281d9aac23d3a082d1c544aa579358271 100644

--- a/xfa/fxfa/app/xfa_rendercontext.cpp

+++ b/xfa/fxfa/app/xfa_rendercontext.cpp

@@ -68,8 +68,6 @@ int32_t CXFA_RenderContext::DoRender(IFX_Pause* pPause) {

return XFA_RENDERSTATUS_Done;

}

void CXFA_RenderContext::StopRender() {

- if (m_pWidgetIterator) {

- m_pWidgetIterator->Release();

- m_pWidgetIterator = NULL;

- }

+ delete m_pWidgetIterator;

+ m_pWidgetIterator = nullptr;

}

« no previous file with comments | « xfa/fxfa/app/xfa_ffpageview.cpp ('k') | xfa/fxfa/include/fxfa.h » ('j') | no next file with comments »